Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Compiler Argument Trait AB Experiment #12979

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support Compiler Argument Trait AB Experiment #12979

wants to merge 1 commit into from
+614 −93

Conversation

kuchungmsft
Copy link
Contributor

@kuchungmsft kuchungmsft commented Nov 19, 2024 •
edited
Loading

  • Depends on cpptools' update to provide ProjectContextResult.
  • Added the following new traits
    • intellisense: compiler information disclaimer.
    • intellisenseBegin: to note the begin of IntelliSense information.
    • compilerArguments: a list of compiler command arguments that could affect Copilot generating completions.
    • directAsks: direct asking Copilot to do something instead of providing an argument.
    • intellisenseEnd: to note the end of IntelliSense information.
  • A/B Experimental flags
    • copilotcppTraits: boolean flag to enable cpp traits
    • copilotcppExcludeTraits: string array to exclude individual trait, i.e., compilerArguments.
    • copilotcppMsvcCompilerArgumentFilter: regex string to match compiler arguments for GCC.
    • copilotcppClangCompilerArgumentFilter: regex string to match compiler arguments for Clang.
    • copilotcppGccCompilerArgumentFilter: regex string to match compiler arguments for MSVC.
    • copilotcppCompilerArgumentDirectAskMap: a stringify map string to map arguments to direct ask statements.

The traits in the following screenshot can be disabled individually via copilotcppExcludeTraits
image

@kuchungmsft kuchungmsft changed the title Support A/B Compiler Arguments Traits Support Compiler Argument Trait AB Experiment Nov 19, 2024
kuchungmsft added a commit to kuchungmsft/vscode-cpptools that referenced this pull request Nov 19, 2024
@kuchungmsft
Support User Defines and Macro References AB Experiment
2672a83 
- Depends on microsoft#12979 to merge first.
- copilotcppMacroReferenceFilter: regex string to filter macro reference for telemetry.
- Telemetry related to user defines and macro references.
- Added new trait compilerUserDefines to note the relevant user defines to the editing file.
@kuchungmsft kuchungmsft mentioned this pull request Nov 19, 2024
Draft
@kuchungmsft kuchungmsft marked this pull request as ready for review November 19, 2024 23:51
@kuchungmsft kuchungmsft force-pushed the kuchung/SupportCompilerArgumentAB branch from 92e251b to ce1c8fe Compare November 20, 2024 00:41
sean-mcmanus
sean-mcmanus previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, but I haven't been able to test it out and you should probably get another approver.

@benmcmorran
Copy link
Member

Pulling this down to test locally now and then I expect to be able to sign off.

@kuchungmsft kuchungmsft force-pushed the kuchung/SupportCompilerArgumentAB branch from ce1c8fe to 7a72866 Compare November 22, 2024 00:40
@kuchungmsft kuchungmsft requested a review from a team as a code owner November 22, 2024 00:40
benmcmorran
benmcmorran previously approved these changes Nov 22, 2024
View reviewed changes
Extension/src/LanguageServer/lmTool.ts Outdated Show resolved Hide resolved
Extension/src/telemetry.ts Outdated Show resolved Hide resolved
Extension/src/LanguageServer/utils.ts Outdated Show resolved Hide resolved
@kuchungmsft
Support A/B Compiler Arguments Traits
4758e15 
- Depends on cpptools' update to provide ProjectContextResult.
- Added the following new traits
  - intelliSenseDisclaimer: compiler information disclaimer.
  - intelliSenseDisclaimerBeginning: to note the beginning of IntelliSense information.
  - compilerArguments: a list of compiler command arguments that could affect Copilot generating completions.
  - directAsks: direct asking Copilot to do something instead of providing an argument.
  - intelliSenseDisclaimerEnd: to note the end of IntelliSense information.
- A/B Experimental flags
  - copilotcppTraits: boolean flag to enable cpp traits
  - copilotcppExcludeTraits: string array to exclude individual trait, i.e., compilerArguments.
  - copilotcppMsvcCompilerArgumentFilter: regex string to match compiler arguments for GCC.
  - copilotcppClangCompilerArgumentFilter: regex string to match compiler arguments for Clang.
  - copilotcppGccCompilerArgumentFilter: regex string to match compiler arguments for MSVC.
  - copilotcppCompilerArgumentDirectAskMap: a stringify map string to map arguments to direct ask statements.
@kuchungmsft kuchungmsft force-pushed the kuchung/SupportCompilerArgumentAB branch from 7a72866 to 4758e15 Compare November 22, 2024 02:02
sean-mcmanus
sean-mcmanus approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, but I don't know if they need to be addressed or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

@benmcmorran benmcmorran benmcmorran left review comments

@marlonwq marlonwq marlonwq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
cpptools
Status: Pull Request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kuchungmsft @benmcmorran @sean-mcmanus @marlonwq