Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an unnecessary cancel/re-request with GitHub Copilot requests. #12988

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −1
Draft

Fix an unnecessary cancel/re-request with GitHub Copilot requests. #12988

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3f59aa
Fix an unnecessary cancel/re-request with GitHub Copilot requests.
sean-mcmanus Nov 22, 2024
e3e37b5
Fix linter error.
sean-mcmanus Nov 22, 2024
8e2e977
Minor change.
sean-mcmanus Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Extension/src/LanguageServer/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2318,8 +2318,10 @@ export class DefaultClient implements Client {
}
}

// Don't cancel if the result has already been computed, because the result might still be usable
// without needing to send an unnecessary re-request, which is the case for the callback to registerRelatedFilesProvider.
if (token.isCancellationRequested) {
throw new vscode.CancellationError();
return result; // throw new vscode.CancellationError();
}

return result;
Expand Down
Loading