Get eslint and Prettier to play nicely with each other#14927
Merged
brettcannon merged 4 commits intomicrosoft:mainfrom Dec 10, 2020
Merged
Get eslint and Prettier to play nicely with each other#14927brettcannon merged 4 commits intomicrosoft:mainfrom
brettcannon merged 4 commits intomicrosoft:mainfrom
Conversation
kimadeline
approved these changes
Dec 10, 2020
We are so going to be specifying types more going forward.
Codecov Report
@@ Coverage Diff @@
## main #14927 +/- ##
======================================
- Coverage 65% 65% -1%
======================================
Files 554 554
Lines 26108 26116 +8
Branches 3704 3705 +1
======================================
- Hits 17080 17073 -7
- Misses 8338 8355 +17
+ Partials 690 688 -2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Along the way also fix any eslint errors that are encountered.
This gets us down to 108 errors via
npx eslint --quiet --ext .ts,.tsx src.