Skip to content

Comments

Get eslint and Prettier to play nicely with each other#14927

Merged
brettcannon merged 4 commits intomicrosoft:mainfrom
brettcannon:eslint-2020-12-09
Dec 10, 2020
Merged

Get eslint and Prettier to play nicely with each other#14927
brettcannon merged 4 commits intomicrosoft:mainfrom
brettcannon:eslint-2020-12-09

Conversation

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Dec 10, 2020

Along the way also fix any eslint errors that are encountered.

This gets us down to 108 errors via npx eslint --quiet --ext .ts,.tsx src.

@brettcannon brettcannon added the no-changelog No news entry required label Dec 10, 2020
@github-actions github-actions bot requested a review from kimadeline December 10, 2020 17:55
@codecov-io
Copy link

codecov-io commented Dec 10, 2020

Codecov Report

Merging #14927 (069a8b0) into main (de8e5f2) will decrease coverage by 0%.
The diff coverage is 29%.

@@          Coverage Diff           @@
##            main   #14927   +/-   ##
======================================
- Coverage     65%      65%   -1%     
======================================
  Files        554      554           
  Lines      26108    26116    +8     
  Branches    3704     3705    +1     
======================================
- Hits       17080    17073    -7     
- Misses      8338     8355   +17     
+ Partials     690      688    -2     
Impacted Files Coverage Δ
src/client/activation/jedi/manager.ts 29% <0%> (-1%) ⬇️
.../application/webviewPanels/webviewPanelProvider.ts 43% <ø> (ø)
src/client/common/application/webviews/webview.ts 15% <0%> (-1%) ⬇️
...t/jupyter/languageserver/notebookConcatDocument.ts 7% <0%> (ø)
...client/jupyter/languageserver/notebookConverter.ts 1% <0%> (ø)
.../jupyter/languageserver/notebookMiddlewareAddon.ts 3% <0%> (-1%) ⬇️
...nments/discovery/locators/services/condaService.ts 83% <0%> (ø)
...rc/client/activation/jedi/multiplexingActivator.ts 17% <20%> (-1%) ⬇️
src/client/activation/jedi/languageServerProxy.ts 25% <50%> (ø)
...experiments/debuggerDataViewerExperimentEnabler.ts 42% <66%> (ø)
... and 8 more

@brettcannon brettcannon merged commit f753af1 into microsoft:main Dec 10, 2020
@brettcannon brettcannon deleted the eslint-2020-12-09 branch December 10, 2020 22:30
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 29.06977% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 65%. Comparing base (de8e5f2) to head (069a8b0).
⚠️ Report is 2675 commits behind head on main.

Files with missing lines Patch % Lines
...client/jupyter/languageserver/notebookConverter.ts 0% 23 Missing ⚠️
.../jupyter/languageserver/notebookMiddlewareAddon.ts 0% 11 Missing ⚠️
src/client/activation/jedi/manager.ts 0% 7 Missing ⚠️
src/client/common/application/webviews/webview.ts 0% 5 Missing ⚠️
...rc/client/activation/jedi/multiplexingActivator.ts 20% 4 Missing ⚠️
src/client/activation/jedi/languageServerProxy.ts 50% 2 Missing ⚠️
...experiments/debuggerDataViewerExperimentEnabler.ts 66% 2 Missing ⚠️
...t/jupyter/languageserver/notebookConcatDocument.ts 0% 2 Missing ⚠️
...nments/discovery/locators/services/condaService.ts 0% 1 Missing and 1 partial ⚠️
...covery/locators/services/windowsRegistryService.ts 81% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #14927   +/-   ##
======================================
- Coverage     65%      65%   -1%     
======================================
  Files        554      554           
  Lines      26108    26116    +8     
  Branches    3704     3705    +1     
======================================
- Hits       17080    17073    -7     
- Misses      8338     8355   +17     
+ Partials     690      688    -2     
Files with missing lines Coverage Δ
.../application/webviewPanels/webviewPanelProvider.ts 43% <ø> (ø)
...overy/locators/services/cacheableLocatorService.ts 75% <100%> (ø)
src/client/tensorBoard/tensorBoardImportTracker.ts 88% <100%> (ø)
...nEnvironments/discovery/locators/services/conda.ts 92% <85%> (ø)
src/client/activation/jedi/languageServerProxy.ts 25% <50%> (ø)
...experiments/debuggerDataViewerExperimentEnabler.ts 42% <66%> (ø)
...t/jupyter/languageserver/notebookConcatDocument.ts 7% <0%> (ø)
...nments/discovery/locators/services/condaService.ts 83% <0%> (ø)
...covery/locators/services/windowsRegistryService.ts 88% <81%> (-1%) ⬇️
...rc/client/activation/jedi/multiplexingActivator.ts 17% <20%> (-1%) ⬇️
... and 4 more

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants