dialogs: Clean up Copilot canary versions (#335096)

Remove the canary and unsigned markers when presenting Copilot runtime and SDK versions in the About dialog.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: roblourens

src/vs/platform/dialogs/electron-browser/dialog.ts

@@ -10,6 +10,10 @@ import { IOSProperties } from '../../native/common/native.js';
 import { IProductService } from '../../product/common/productService.js';
 import { process } from '../../../base/parts/sandbox/electron-browser/globals.js';
 
+function formatCopilotVersion(version: string | undefined): string {
+	return version?.replace('-canary', '').replace(/\.unsigned$/, '') || 'Unknown';
+}
+
 export function createNativeAboutDialogDetails(productService: IProductService, osProps: IOSProperties): { title: string; details: string; detailsToCopy: string } {
 	let version = productService.version;
 	if (productService.target) {
@@ -18,6 +22,9 @@ export function createNativeAboutDialogDetails(productService: IProductService,
 		version = `${version} (Universal)`;
 	}
 
+	const copilotRuntimeVersion = formatCopilotVersion(productService.copilotVersions?.runtime);
+	const copilotSdkVersion = formatCopilotVersion(productService.copilotVersions?.sdk);
+
 	const getDetails = (useAgo: boolean): string => {
 		return localize({ key: 'aboutDetail', comment: ['Electron, Chromium, Node.js, V8 and Copilot are product names that need no translation'] },
 			"Version: {0}\nCommit: {1}\nDate: {2}\nElectron: {3}\nElectronBuildId: {4}\nChromium: {5}\nNode.js: {6}\nV8: {7}\n@github/copilot: {8}\n@github/copilot-sdk: {9}\nOS: {10}",
@@ -29,8 +36,8 @@ export function createNativeAboutDialogDetails(productService: IProductService,
 			process.versions['chrome'],
 			process.versions['node'],
 			process.versions['v8'],
-			productService.copilotVersions?.runtime || 'Unknown',
-			productService.copilotVersions?.sdk || 'Unknown',
+			copilotRuntimeVersion,
+			copilotSdkVersion,
 			`${osProps.type} ${osProps.arch} ${osProps.release}${isLinuxSnap ? ' snap' : ''}`
 		);
 	};

src/vs/platform/dialogs/test/electron-browser/dialog.test.ts

@@ -0,0 +1,71 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import assert from 'assert';
+import { ensureNoDisposablesAreLeakedInTestSuite } from '../../../../base/test/common/utils.js';
+import { IOSProperties } from '../../../native/common/native.js';
+import product from '../../../product/common/product.js';
+import { IProductService } from '../../../product/common/productService.js';
+import { createNativeAboutDialogDetails } from '../../electron-browser/dialog.js';
+
+suite('Dialog', () => {
+
+	ensureNoDisposablesAreLeakedInTestSuite();
+
+	const osProperties: IOSProperties = {
+		type: 'Test OS',
+		release: '1.0',
+		arch: 'test-arch',
+		platform: 'test',
+		cpus: []
+	};
+
+	function getCopilotVersionLines(runtime: string, sdk: string): { details: string[]; detailsToCopy: string[] } {
+		const productService: IProductService = {
+			_serviceBrand: undefined,
+			...product,
+			copilotVersions: { runtime, sdk }
+		};
+		const { details, detailsToCopy } = createNativeAboutDialogDetails(productService, osProperties);
+		const selectCopilotVersionLines = (value: string) => value.split('\n').filter(line => line.startsWith('@github/copilot'));
+
+		return {
+			details: selectCopilotVersionLines(details),
+			detailsToCopy: selectCopilotVersionLines(detailsToCopy)
+		};
+	}
+
+	test('formats Copilot canary versions', () => {
+		assert.deepStrictEqual(
+			getCopilotVersionLines('1.0.84-canary.70.gdb75d0d.unsigned', '0.1.23-canary.45.gabcdef.unsigned'),
+			{
+				details: [
+					'@github/copilot: 1.0.84.70.gdb75d0d',
+					'@github/copilot-sdk: 0.1.23.45.gabcdef'
+				],
+				detailsToCopy: [
+					'@github/copilot: 1.0.84.70.gdb75d0d',
+					'@github/copilot-sdk: 0.1.23.45.gabcdef'
+				]
+			}
+		);
+	});
+
+	test('preserves stable Copilot versions', () => {
+		assert.deepStrictEqual(
+			getCopilotVersionLines('1.0.84', '0.1.23'),
+			{
+				details: [
+					'@github/copilot: 1.0.84',
+					'@github/copilot-sdk: 0.1.23'
+				],
+				detailsToCopy: [
+					'@github/copilot: 1.0.84',
+					'@github/copilot-sdk: 0.1.23'
+				]
+			}
+		);
+	});
+});