Skip to content

Commit 26d4a47

Browse files
chrywCopilot
andcommitted
sessions: align pending checks with GitHub
Use the familiar static pending dot and aggregate 'Checks pending' label rather than a sync metaphor that implies active execution or refresh. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent f04897c commit 26d4a47

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/vs/sessions/contrib/chat/test/browser/sessionChatInputToolbar.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -701,7 +701,7 @@ suite('SessionChatInputToolbar', () => {
701701
}, {
702702
states: ['draft', 'closed', 'open', 'closed', 'merged', 'merged', 'open'],
703703
descriptions: [
704-
'draft. Checks running. https://github.com/microsoft/vscode/pull/1',
704+
'draft. Checks pending. https://github.com/microsoft/vscode/pull/1',
705705
'closed. https://github.com/microsoft/vscode/pull/1',
706706
'failing checks. https://github.com/microsoft/vscode/pull/1',
707707
],

src/vs/sessions/contrib/github/browser/pullRequestHover.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ function getPullRequestChecksStatus(pullRequest: IGitHubPullRequest, ciStatus: G
135135
}
136136
switch (ciStatus) {
137137
case GitHubCIOverallStatus.Pending:
138-
return { kind: 'pending', label: localize('agentSessions.pullRequestHover.checksRunning', "Checks running"), icon: Codicon.syncCompact };
138+
return { kind: 'pending', label: localize('agentSessions.pullRequestHover.checksPending', "Checks pending"), icon: Codicon.circleFilledCompact };
139139
case GitHubCIOverallStatus.Failure:
140140
return { kind: 'failure', label: localize('agentSessions.pullRequestHover.checksFailed', "Checks failed"), icon: Codicon.errorCompact };
141141
case GitHubCIOverallStatus.Success:

src/vs/sessions/contrib/github/test/browser/pullRequestHover.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ suite('createPullRequestHover', () => {
105105
draft: render(GitHubCIOverallStatus.Success, makePullRequest({ isDraft: true })),
106106
merged: render(GitHubCIOverallStatus.Success, makePullRequest({ state: GitHubPullRequestState.Merged })),
107107
}, {
108-
pending: { text: 'Checks running', status: 'pending', icon: 'codicon codicon-sync-compact', iconAriaHidden: 'true' },
108+
pending: { text: 'Checks pending', status: 'pending', icon: 'codicon codicon-circle-filled-compact', iconAriaHidden: 'true' },
109109
success: { text: 'Checks passed', status: 'success', icon: 'codicon codicon-pass-filled-compact', iconAriaHidden: 'true' },
110110
failure: { text: 'Checks failed', status: 'failure', icon: 'codicon codicon-error-compact', iconAriaHidden: 'true' },
111111
neutral: { text: undefined, status: undefined, icon: undefined, iconAriaHidden: undefined },

0 commit comments

Comments
 (0)