agentHost: Offer SDK download independent of sign-in

Check for a missing SDK before account, entitlement, and signed-out experiment gates so every user can consent to the required download. Keep missing-account guidance behind the existing signed-out checks and cover both sides of the decision boundary.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: TylerLeonhardt

src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostSdkSetupNotification.ts

@@ -26,7 +26,7 @@ import { ILanguageModelsService } from '../../../common/languageModels.js';
 
 /** Everything one agent's {@link AgentSdkSetupState} is decided from. */
 export interface IAgentSdkSetupStateInputs {
-	/** The experimentation flag this whole feature stays behind. */
+	/** The experimentation flag the missing-account routes stay behind. Not the download offer. */
 	readonly allowSignedOutWhenUsable: boolean;
 	/** Whether the user is signed in to GitHub (Copilot models already work). */
 	readonly signedIn: boolean;
@@ -41,28 +41,29 @@ export interface IAgentSdkSetupStateInputs {
 
 /**
  * The whole decision, as one pure function: what the banner renders and what the
- * funnel records are two readings of this one state. A signed-in user already
- * has Copilot models, so there is nothing to offer and BYOK stays undiscoverable
- * for them (a deliberate v1 cut).
+ * funnel records are two readings of this one state.
+ *
+ * The download is offered before any other check, because it applies to
+ * everyone: we fetch a large SDK onto the user's machine, and that is worth
+ * saying whether or not they have models already.
  */
 export function getAgentSdkSetupState(inputs: IAgentSdkSetupStateInputs): AgentSdkSetupState | undefined {
+	if (inputs.download === 'notDownloaded') {
+		// A request we sent covers the gap before the host answers it, so standing
+		// consent (or a click) never flashes the offer it has already satisfied.
+		return inputs.downloadRequested ? undefined : 'downloadOffered';
+	}
+	// Everything below explains a missing account, which is the signed-out
+	// experiment and stays behind its flag.
 	if (!inputs.allowSignedOutWhenUsable || !inputs.entitlementResolved || inputs.signedIn) {
 		return undefined;
 	}
-	// Ahead of the download status because models are the honest end state: an
-	// agent that can enumerate a catalog has an account, whatever a status claims.
 	if (inputs.hasModels) {
 		return 'resolved';
 	}
-	switch (inputs.download) {
-		// A fetch in flight has nothing to ask for — the host drives its own
-		// progress notification while it runs.
-		case 'downloading': return undefined;
-		// A request we sent covers the gap before the host answers it, so standing
-		// consent (or a click) never flashes the offer it has already satisfied.
-		case 'notDownloaded': return inputs.downloadRequested ? undefined : 'downloadOffered';
-		case 'ready': return 'noAccount';
-	}
+	// A fetch in flight has nothing to ask for — the host drives its own
+	// progress notification while it runs.
+	return inputs.download === 'downloading' ? undefined : 'noAccount';
 }
 
 /**

src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostSdkSetupNotification.test.ts

@@ -39,10 +39,17 @@ suite('Agent SDK setup banner', () => {
 			{ name: 'a request the host has not answered yet is not a fresh offer', inputs: { ...BLOCKED_USER, downloadRequested: true }, expected: undefined },
 			{ name: 'SDK on disk reporting no models means no account', inputs: { ...BLOCKED_USER, download: 'ready' }, expected: 'noAccount' },
 			{ name: 'models are the honest end state, whatever the status says', inputs: { ...BLOCKED_USER, download: 'ready', hasModels: true }, expected: 'resolved' },
-			{ name: 'a signed-in user already has Copilot models', inputs: { ...BLOCKED_USER, signedIn: true }, expected: undefined },
-			{ name: 'nothing shows until entitlement settles, since "signed out" is not yet a fact', inputs: { ...BLOCKED_USER, entitlementResolved: false }, expected: undefined },
-			{ name: 'the whole feature stays behind its flag', inputs: { ...BLOCKED_USER, allowSignedOutWhenUsable: false }, expected: undefined },
+			{ name: 'nothing shows until entitlement settles, since "signed out" is not yet a fact', inputs: { ...BLOCKED_USER, download: 'ready', entitlementResolved: false }, expected: undefined },
+			{ name: 'the missing-account explanation stays behind its flag', inputs: { ...BLOCKED_USER, download: 'ready', allowSignedOutWhenUsable: false }, expected: undefined },
+			{ name: 'a signed-in user is never told they have no account', inputs: { ...BLOCKED_USER, download: 'ready', signedIn: true }, expected: undefined },
 			{ name: 'a signed-in user mid-download is still shown nothing', inputs: { ...BLOCKED_USER, signedIn: true, download: 'downloading' }, expected: undefined },
+
+			// The download is offered to everyone: each of these users can work
+			// today, and still has an SDK we are about to fetch onto their machine.
+			{ name: 'a signed-in user is offered the download too', inputs: { ...BLOCKED_USER, signedIn: true }, expected: 'downloadOffered' },
+			{ name: 'having models does not hide the download', inputs: { ...BLOCKED_USER, signedIn: true, hasModels: true }, expected: 'downloadOffered' },
+			{ name: 'the download offer does not wait for entitlement', inputs: { ...BLOCKED_USER, entitlementResolved: false }, expected: 'downloadOffered' },
+			{ name: 'the download offer is not behind the signed-out flag', inputs: { ...BLOCKED_USER, allowSignedOutWhenUsable: false }, expected: 'downloadOffered' },
 		];
 
 		for (const { name, inputs, expected } of cases) {