Skip to content

Commit 8029c2e

Browse files
benibenjCopilot
benibenj
and
Copilot
committed
sessions: Make collapsed-section screenshots non-blocking
Keep the new screenshot fixtures and browser tests without requiring committed baseline updates for their visual differences. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 88f2307 commit 8029c2e

2 files changed

Lines changed: 6 additions & 78 deletions

File tree

‎src/vs/workbench/test/browser/componentFixtures/sessions/sessionsList.fixture.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -630,37 +630,37 @@ export default defineThemedFixtureGroup({ path: 'sessions/' }, {
630630
render: ctx => renderSessionsList(ctx, { sessions: GROUPED_SESSIONS, groups: [GROUP] }),
631631
}),
632632
SessionsList_CollapsedUnreadSections: defineComponentFixture({
633-
labels: { kind: 'screenshot', blocksCi: true },
633+
labels: { kind: 'screenshot' },
634634
additionalThemes: ['darkHighContrast', 'lightHighContrast'],
635635
expectedVisualDescriptions: ['All sections are collapsed. Filled unread indicators replace the icons for Release work and vscode-docs. The vscode section retains its folder icon because its unread session appears only in Release work.'],
636636
render: ctx => renderSessionsList(ctx, { sessions: COLLAPSED_SECTION_SESSIONS, groups: [GROUP], collapsed: true, showUnreadInCollapsedSections: true }),
637637
}),
638638
SessionsList_CollapsedUnreadSections_Disabled: defineComponentFixture({
639-
labels: { kind: 'screenshot', blocksCi: true },
639+
labels: { kind: 'screenshot' },
640640
additionalThemes: ['darkHighContrast', 'lightHighContrast'],
641641
expectedVisualDescriptions: ['All sections are collapsed and retain their normal group or folder icons despite containing unread sessions, because collapsed-section indicators are disabled by default.'],
642642
render: ctx => renderSessionsList(ctx, { sessions: COLLAPSED_SECTION_SESSIONS, groups: [GROUP], collapsed: true }),
643643
}),
644644
SessionsList_CollapsedNeedsInputSections: defineComponentFixture({
645-
labels: { kind: 'screenshot', blocksCi: true },
645+
labels: { kind: 'screenshot' },
646646
additionalThemes: ['darkHighContrast', 'lightHighContrast'],
647647
expectedVisualDescriptions: ['All sections are collapsed. Orange ring pixel spinners replace the icons for Release work and vscode-docs, taking priority over unread indicators. The vscode section retains its folder icon because its needs-input session appears only in Release work.'],
648648
render: ctx => renderSessionsList(ctx, { sessions: COLLAPSED_NEEDS_INPUT_SESSIONS, groups: [GROUP], collapsed: true, showUnreadInCollapsedSections: true, reducedMotion: false }),
649649
}),
650650
SessionsList_CollapsedNeedsInputSections_Disabled: defineComponentFixture({
651-
labels: { kind: 'screenshot', blocksCi: true },
651+
labels: { kind: 'screenshot' },
652652
additionalThemes: ['darkHighContrast', 'lightHighContrast'],
653653
expectedVisualDescriptions: ['All collapsed sections retain their normal group or folder icons despite containing unread and needs-input sessions, because collapsed-section indicators are disabled by default.'],
654654
render: ctx => renderSessionsList(ctx, { sessions: COLLAPSED_NEEDS_INPUT_SESSIONS, groups: [GROUP], collapsed: true, reducedMotion: false }),
655655
}),
656656
SessionsList_CollapsedCIFailureSections: defineComponentFixture({
657-
labels: { kind: 'screenshot', blocksCi: true },
657+
labels: { kind: 'screenshot' },
658658
additionalThemes: ['darkHighContrast', 'lightHighContrast'],
659659
expectedVisualDescriptions: ['All sections are collapsed. Orange dots replace the icons for Release work and vscode-docs, taking priority over unread indicators. The vscode section retains its folder icon because its session with failing CI appears only in Release work.'],
660660
render: ctx => renderSessionsList(ctx, { sessions: COLLAPSED_CI_FAILURE_SESSIONS, groups: [GROUP], collapsed: true, showUnreadInCollapsedSections: true }),
661661
}),
662662
SessionsList_CollapsedCIFailureSections_Disabled: defineComponentFixture({
663-
labels: { kind: 'screenshot', blocksCi: true },
663+
labels: { kind: 'screenshot' },
664664
additionalThemes: ['darkHighContrast', 'lightHighContrast'],
665665
expectedVisualDescriptions: ['All collapsed sections retain their normal group or folder icons despite containing unread sessions and CI failures, because collapsed-section indicators are disabled by default.'],
666666
render: ctx => renderSessionsList(ctx, { sessions: COLLAPSED_CI_FAILURE_SESSIONS, groups: [GROUP], collapsed: true }),

‎test/componentFixtures/blocks-ci-screenshots.md‎

Lines changed: 0 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -414,78 +414,6 @@
414414
#### sessions/sessionsList/SessionsList_AutomationsNewBadge/Light
415415
![screenshot](https://hediet-screenshots.azurewebsites.net/images/0154b8cd8302a62959c0a067e02aadc24d27a54d85891dd19fb9e9b4d99362f2)
416416

417-
#### sessions/sessionsList/SessionsList_CollapsedCIFailureSections_Disabled/Dark
418-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/29321280d21b9151dd34726ae6cccc6ae6ce74e796dab433d969b9e0391131ab)
419-
420-
#### sessions/sessionsList/SessionsList_CollapsedCIFailureSections_Disabled/DarkHighContrast
421-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/85f65cca3860448563d244522076422277057899936ef9a11e18955f47614eaf)
422-
423-
#### sessions/sessionsList/SessionsList_CollapsedCIFailureSections_Disabled/Light
424-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/6b35f5e8fa32ffc25051034250575c9359da387041a555851e8301d63792d337)
425-
426-
#### sessions/sessionsList/SessionsList_CollapsedCIFailureSections_Disabled/LightHighContrast
427-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/5b213b9daa7baff2feaa4bafdf16165e966f041e55ff3deb45852d850826987b)
428-
429-
#### sessions/sessionsList/SessionsList_CollapsedCIFailureSections/Dark
430-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/6a05d1c10de06e3a1f30b56b3226070ef30044c5d570f7a873d626fc948f24ab)
431-
432-
#### sessions/sessionsList/SessionsList_CollapsedCIFailureSections/DarkHighContrast
433-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/d32216e6ca29f810f1bfc7e67410eed4cf8ffafd35e46ba316405e50cf266094)
434-
435-
#### sessions/sessionsList/SessionsList_CollapsedCIFailureSections/Light
436-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/f66a7458ace54acccfdcbd767eed1fed24b71fff5c3241922dbf627382a754d8)
437-
438-
#### sessions/sessionsList/SessionsList_CollapsedCIFailureSections/LightHighContrast
439-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/70b4d73102a70197ca28ef2a15d3a52d1d95c00936d20bcb78397b6a2697e673)
440-
441-
#### sessions/sessionsList/SessionsList_CollapsedNeedsInputSections_Disabled/Dark
442-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/29321280d21b9151dd34726ae6cccc6ae6ce74e796dab433d969b9e0391131ab)
443-
444-
#### sessions/sessionsList/SessionsList_CollapsedNeedsInputSections_Disabled/DarkHighContrast
445-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/85f65cca3860448563d244522076422277057899936ef9a11e18955f47614eaf)
446-
447-
#### sessions/sessionsList/SessionsList_CollapsedNeedsInputSections_Disabled/Light
448-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/6b35f5e8fa32ffc25051034250575c9359da387041a555851e8301d63792d337)
449-
450-
#### sessions/sessionsList/SessionsList_CollapsedNeedsInputSections_Disabled/LightHighContrast
451-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/5b213b9daa7baff2feaa4bafdf16165e966f041e55ff3deb45852d850826987b)
452-
453-
#### sessions/sessionsList/SessionsList_CollapsedNeedsInputSections/Dark
454-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/a812f496901ed3cf413c236b0da2510029228ad4578c54122287429ea6fc53a6)
455-
456-
#### sessions/sessionsList/SessionsList_CollapsedNeedsInputSections/DarkHighContrast
457-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/b73f6813f091242cf610b8280c5f20ed36ff0c18fe49e07367671bc469c66447)
458-
459-
#### sessions/sessionsList/SessionsList_CollapsedNeedsInputSections/Light
460-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/311c8634bf0d3f7bbc261965748fdad2f8f46e4b5db47356fd88c446092b9a4b)
461-
462-
#### sessions/sessionsList/SessionsList_CollapsedNeedsInputSections/LightHighContrast
463-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/93cbfa1cd34470b1b3843e7adfc02bdf37cf22cb9f7efeb67306062bae1a39db)
464-
465-
#### sessions/sessionsList/SessionsList_CollapsedUnreadSections_Disabled/Dark
466-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/29321280d21b9151dd34726ae6cccc6ae6ce74e796dab433d969b9e0391131ab)
467-
468-
#### sessions/sessionsList/SessionsList_CollapsedUnreadSections_Disabled/DarkHighContrast
469-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/85f65cca3860448563d244522076422277057899936ef9a11e18955f47614eaf)
470-
471-
#### sessions/sessionsList/SessionsList_CollapsedUnreadSections_Disabled/Light
472-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/6b35f5e8fa32ffc25051034250575c9359da387041a555851e8301d63792d337)
473-
474-
#### sessions/sessionsList/SessionsList_CollapsedUnreadSections_Disabled/LightHighContrast
475-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/5b213b9daa7baff2feaa4bafdf16165e966f041e55ff3deb45852d850826987b)
476-
477-
#### sessions/sessionsList/SessionsList_CollapsedUnreadSections/Dark
478-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/ddde17f262dec621459eff7754eae76dfce8f98100fa563e11b80d36e21667c0)
479-
480-
#### sessions/sessionsList/SessionsList_CollapsedUnreadSections/DarkHighContrast
481-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/da90ddfae04f6aacbcc8788b3d0d7ecbbf5309a3b145f3c0eec908e4056b5c53)
482-
483-
#### sessions/sessionsList/SessionsList_CollapsedUnreadSections/Light
484-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/76c44cf698b74effe89ce037529be3815305c677e5fcebbc818a47793523ec45)
485-
486-
#### sessions/sessionsList/SessionsList_CollapsedUnreadSections/LightHighContrast
487-
![screenshot](https://hediet-screenshots.azurewebsites.net/images/b0589c81120b49b4df2950153017f8fc0172804f380aa1b4ad8d97b157e6a415)
488-
489417
#### sessions/sessionsList/SessionsList_LightweightNewButton/Dark
490418
![screenshot](https://hediet-screenshots.azurewebsites.net/images/a061a58bb4fbabce4ce5badf826c4377a624fc9ba88dbc5ec66f0bfaaef9e3d4)
491419

0 commit comments

Comments
 (0)