sessions: handle duplicate dialog failures

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a713c12c-1a43-4f7f-9337-fca7f8dfe89f

Author: benvillalobos

src/vs/sessions/contrib/sessions/browser/views/automationsView.ts

@@ -1355,27 +1355,27 @@ registerAction2(class DuplicateAutomationAction extends Action2 {
 			return;
 		}
 
-		const name = getDuplicateAutomationName(automation.name, automationService.automations.get());
-		const result = await automationDialogService.showAutomationDialog({
-			initialValues: {
-				name,
-				prompt: automation.prompt,
-				schedule: automation.schedule,
-				target: automation.target,
-				modelId: automation.modelId,
-				mode: automation.mode,
-				permissionLevel: automation.permissionLevel,
-				enabled: automation.enabled,
-			},
-		});
-		if (!result || result.kind !== 'create') {
-			return;
-		}
-		if (!isEnabled()) {
-			await showAutomationsDisabled(dialogService);
-			return;
-		}
 		try {
+			const name = getDuplicateAutomationName(automation.name, automationService.automations.get());
+			const result = await automationDialogService.showAutomationDialog({
+				initialValues: {
+					name,
+					prompt: automation.prompt,
+					schedule: automation.schedule,
+					target: automation.target,
+					modelId: automation.modelId,
+					mode: automation.mode,
+					permissionLevel: automation.permissionLevel,
+					enabled: automation.enabled,
+				},
+			});
+			if (!result || result.kind !== 'create') {
+				return;
+			}
+			if (!isEnabled()) {
+				await showAutomationsDisabled(dialogService);
+				return;
+			}
 			const duplicate = await automationService.createAutomation(result.value, () => {
 				if (!isEnabled()) {
 					throw new Error(localize('automationsDisabledBeforeDuplicate', "Automations were disabled before the duplicate could be saved."));

src/vs/sessions/contrib/sessions/test/browser/automationsView.test.ts

@@ -899,6 +899,35 @@ suite('AutomationsCardsWidget', () => {
 		});
 	});
 
+	test('duplicate dialog failures are logged and reported to the user', async () => {
+		const { automationDialogService, automationService, dialogService, instantiationService, logService } = setup();
+		const source = automation();
+		const error = new Error('dialog failed');
+		automationDialogService.error = error;
+		automationService.setAutomations([source]);
+		const command = CommandsRegistry.getCommand('sessions.automations.duplicate');
+		assert.ok(command);
+
+		await instantiationService.invokeFunction(accessor => command.handler(accessor, source));
+		await dialogService.errorCalled.p;
+
+		assert.deepStrictEqual({
+			createCalls: automationService.createCalls,
+			loggedErrors: logService.errors,
+			dialogErrors: dialogService.errors,
+		}, {
+			createCalls: [],
+			loggedErrors: [{
+				message: '[Automations] Failed to duplicate automation',
+				args: [error],
+			}],
+			dialogErrors: [{
+				message: 'Failed to duplicate automation.',
+				detail: 'dialog failed',
+			}],
+		});
+	});
+
 	test('duplicate creation failures are logged and reported to the user', async () => {
 		const { automationDialogService, automationService, contextKeyService, contextMenuService, dialogService, instantiationService, logService, widget } = setup();
 		const source = automation();