Drop the write permission adaptation

The write path restated the host's file name as a markdown link so the
confirmation card and sessions list would show a file pill. That
duplicates information a host can supply directly, so it would have
become dead code rather than a lasting fix. Tracked separately with
the agent host team.

The command path stays. It is not compensating for a host deviation:
the Agent Host Protocol has no field that identifies a pending tool
call as a shell command, so `_meta.toolKind` (a VS Code-private hint a
remote host has no reason to set) is the only signal, and without the
fallback a sandbox command approval shows the agent's intention
instead of the command being approved.

Reverts the getEditFileMessage extraction, the write branch and its
Windows path normalization, the write fields on the permission meta
reader, and the three write tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: osortega

src/vs/platform/agentHost/common/meta/agentPermissionRequestMeta.ts

@@ -26,14 +26,10 @@ export const enum AgentPermissionRequestKind {
 	Commands = 'commands',
 	/** Read a single file. */
 	Read = 'read',
-	/** Write to a single file. */
-	Write = 'write',
 }
 
 export interface IAgentPermissionRequestMeta {
 	readonly kind?: AgentPermissionRequestKind;
-	/** Absolute path of the file a write request targets. */
-	readonly fileName?: string;
 }
 
 /**
@@ -50,17 +46,16 @@ function normalizeKind(value: unknown): AgentPermissionRequestKind | undefined {
 			return AgentPermissionRequestKind.Commands;
 		case 'read':
 			return AgentPermissionRequestKind.Read;
-		case 'write':
-			return AgentPermissionRequestKind.Write;
 		default:
 			return undefined;
 	}
 }
 
-function readRequest(value: unknown): Record<string, unknown> | undefined {
-	return value && typeof value === 'object' && !Array.isArray(value)
-		? value as Record<string, unknown>
-		: undefined;
+function readKind(value: unknown): AgentPermissionRequestKind | undefined {
+	if (!value || typeof value !== 'object' || Array.isArray(value)) {
+		return undefined;
+	}
+	return normalizeKind((value as Record<string, unknown>)['kind']);
 }
 
 /**
@@ -75,14 +70,6 @@ export function readAgentPermissionRequestMeta(source: IHasPermissionRequestMeta
 	if (!meta) {
 		return {};
 	}
-	const prompt = readRequest(meta['promptRequest']);
-	const permission = readRequest(meta['permissionRequest']);
-	const kind = normalizeKind(prompt?.['kind']) ?? normalizeKind(permission?.['kind']);
-	if (!kind) {
-		return {};
-	}
-	const fileName = prompt?.['fileName'] ?? permission?.['fileName'];
-	return typeof fileName === 'string' && fileName
-		? { kind, fileName }
-		: { kind };
+	const kind = readKind(meta['promptRequest']) ?? readKind(meta['permissionRequest']);
+	return kind ? { kind } : {};
 }

src/vs/platform/agentHost/common/streamingToolCallDisplay.ts

@@ -51,20 +51,6 @@ export function streamingToolTextLineCount(value: unknown): number | undefined {
 	return typeof value === 'string' ? splitLines(value).length : undefined;
 }
 
-/**
- * The message naming an edit's target file, e.g. `Edit [index.js](file:///…)`.
- *
- * Shared so every agent host presents an edit the same way: the local adapters
- * build it from the tool's `path` argument, and the client rebuilds it for a
- * remote host that names the file separately from its message.
- */
-export function getEditFileMessage(path: unknown, resolvePath: ToolPathResolver = identityPathResolver): StringOrMarkdown {
-	const file = formatPath(path, resolvePath);
-	return file
-		? markdown(localize('toolInvoke.editFile', "Edit {0}", file))
-		: localize('toolInvoke.edit', "Edit file");
-}
-
 export function getStreamingEditMessage(
 	path: unknown,
 	lineCount: number | undefined,

src/vs/platform/agentHost/node/copilot/copilotToolDisplay.ts

@@ -16,7 +16,7 @@ import { stripRedundantCdPrefix } from '../../common/commandLineHelpers.js';
 import { parsePartialToolInput } from '../../common/partialToolInput.js';
 import { StringOrMarkdown } from '../../common/state/protocol/state.js';
 import { basename, extUriBiasedIgnorePathCase } from '../../../../base/common/resources.js';
-import { getStreamingCreateMessage, getStreamingInsertMessage, getStreamingPatchMessage, getStreamingReplaceMessage, getEditFileMessage, streamingToolTextLineCount, type ToolPathResolver } from '../../common/streamingToolCallDisplay.js';
+import { getStreamingCreateMessage, getStreamingInsertMessage, getStreamingPatchMessage, getStreamingReplaceMessage, streamingToolTextLineCount, type ToolPathResolver } from '../../common/streamingToolCallDisplay.js';
 import { getServerToolDisplay } from '../shared/serverToolGroups.js';
 
 // =============================================================================
@@ -690,7 +690,10 @@ export function getInvocationMessage(toolName: string, displayName: string, para
 		case CopilotToolName.Edit:
 		case CopilotToolName.StrReplace: {
 			const args = parameters as ICopilotFileToolArgs | undefined;
-			return getEditFileMessage(args?.path, resolvePath);
+			if (typeof args?.path === 'string' && args.path) {
+				return md(localize('toolInvoke.editFile', "Edit {0}", formatPathAsMarkdownLink(resolvePath(args.path))));
+			}
+			return localize('toolInvoke.edit', "Edit file");
 		}
 		case CopilotToolName.Insert: {
 			const args = parameters as ICopilotFileToolArgs | undefined;

src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/stateToProgressAdapter.ts

@@ -17,8 +17,6 @@ import { buildSubagentChatUri, getTurnError, isMessageHiddenFromTranscript, Mess
 import type { ChatInputRequestWithPlanReview, IAgentHostPlanReview } from '../../../../../../platform/agentHost/common/agentHostPlanReview.js';
 import { getToolKind } from '../../../../../../platform/agentHost/common/state/sessionReducers.js';
 import { readToolCallMeta } from '../../../../../../platform/agentHost/common/meta/agentToolCallMeta.js';
-import { AgentPermissionRequestKind, readAgentPermissionRequestMeta } from '../../../../../../platform/agentHost/common/meta/agentPermissionRequestMeta.js';
-import { getEditFileMessage } from '../../../../../../platform/agentHost/common/streamingToolCallDisplay.js';
 import { getChatErrorDetailsFromMeta, IChatErrorContext } from '../../../common/chatErrorMessages.js';
 import { AGENT_HOST_SCHEME, createAgentHostResourceUriMapper, type IAgentHostResourceUriMapper, toAgentHostContentUri, toAgentHostUri } from '../../../../../../platform/agentHost/common/agentHostUri.js';
 import { AgentHostElementAttachmentDisplayKind, getElementAttachmentCorrelationId } from '../../../../../../platform/agentHost/common/meta/agentElementAttachments.js';
@@ -2334,9 +2332,7 @@ export function toolCallStateToInvocation(tc: ToolCallState, subAgentInvocationI
 			};
 		} else if (getToolKind(tc) === 'terminal' && getInlineToolInput(tc.toolInput)) {
 			toolSpecificData = buildTerminalToolSpecificData(tc, sessionResource);
-		} else if (!remoteWriteInvocationMessage(tc)) {
-			// A write's only argument is the file the message already names,
-			// so there is nothing left for the raw input view to add.
+		} else {
 			const toolInput = getInlineToolInput(tc.toolInput);
 			if (toolInput) {
 				let rawInput: unknown;
@@ -2347,7 +2343,7 @@ export function toolCallStateToInvocation(tc: ToolCallState, subAgentInvocationI
 
 		return new ChatToolInvocation(
 			{
-				invocationMessage: stringOrMarkdownToString(remoteWriteInvocationMessage(tc) ?? tc.invocationMessage, connectionAuthority),
+				invocationMessage: stringOrMarkdownToString(tc.invocationMessage, connectionAuthority),
 				confirmationMessages,
 				presentation: ToolInvocationPresentation.HiddenAfterComplete,
 				toolSpecificData,
@@ -2413,28 +2409,6 @@ export function toolCallStateToInvocation(tc: ToolCallState, subAgentInvocationI
 	return invocation;
 }
 
-/**
- * The invocation message for a remote host's write permission.
- *
- * A remote host names the target file in `_meta` and sends a plain-text
- * message, where a local host sends the shared `Edit <file link>` message.
- * Restating it in that form is what gives both hosts the same file pill, in
- * the confirmation card and anywhere else the message is summarized.
- *
- * The path is normalized the same way {@link parseAbsoluteFileLinkTarget}
- * normalizes a remote link: `URI.file` only rewrites separators when the
- * *client* runs Windows, so a Windows host paired with a non-Windows client
- * would otherwise keep `C:\repo\file.ts` verbatim and yield a single-segment
- * basename. The link itself stays a plain `file:` URI, exactly as a local host
- * emits it; {@link stringOrMarkdownToString} rewrites it to address the host.
- */
-function remoteWriteInvocationMessage(tc: ToolCallPendingConfirmationState): StringOrMarkdown | undefined {
-	const { kind, fileName } = readAgentPermissionRequestMeta(tc);
-	return kind === AgentPermissionRequestKind.Write && fileName
-		? getEditFileMessage(fileName, path => win32.isAbsolute(path) ? path.replaceAll('\\', '/') : path)
-		: undefined;
-}
-
 export function toolCallConfirmationMessages(tc: ToolCallPendingConfirmationState, connectionAuthority: string): IToolConfirmationMessages {
 	const riskAssessment = tc.riskAssessment;
 	let approvalReason: IToolConfirmationMessages['approvalReason'];
@@ -2453,7 +2427,7 @@ export function toolCallConfirmationMessages(tc: ToolCallPendingConfirmationStat
 			: stringOrMarkdownToString(tc.confirmationTitle, connectionAuthority) ?? tc.displayName,
 		message: isViewUnreviewedCommentsTool(tc.toolName)
 			? localize('agentFeedback.reviewMessage', "Choose which comments to reveal to the agent. Unchecked comments stay hidden.")
-			: stringOrMarkdownToString(remoteWriteInvocationMessage(tc) ?? tc.invocationMessage, connectionAuthority),
+			: stringOrMarkdownToString(tc.invocationMessage, connectionAuthority),
 		approvalReason,
 		...(tc.options ? { customOptions: tc.options } : {}),
 	};

src/vs/workbench/contrib/chat/test/browser/agentSessions/stateToProgressAdapter.test.ts

@@ -1613,94 +1613,6 @@ suite('stateToProgressAdapter', () => {
 			assert.strictEqual(invocation.toolSpecificData?.kind, 'input');
 		});
 
-		test('restates a remote host write permission in the local shape', () => {
-			// A remote host names the file in `_meta` and sends a plain-text
-			// message; a local host sends the shared `Edit <link>` message.
-			// Both the confirmation card and the sessions list read
-			// `invocationMessage`, so it must carry the file too.
-			const tc: ToolCallPendingConfirmationState = {
-				toolCallId: 'tc-write',
-				toolName: 'str_replace_editor',
-				displayName: 'Edit',
-				invocationMessage: 'Edit file',
-				status: ToolCallStatus.PendingConfirmation,
-				confirmationTitle: 'Edit file',
-				toolInput: '/workspaces/simple-server/index.js',
-				_meta: {
-					requestId: 'req-w',
-					promptRequest: { kind: 'write', fileName: '/workspaces/simple-server/index.js' },
-				},
-			};
-
-			const invocation = toolCallStateToInvocation(tc);
-			const state = invocation.state.get();
-			const message = state.type === IChatToolInvocation.StateKind.WaitingForConfirmation
-				? state.confirmationMessages?.message
-				: undefined;
-
-			assert.deepStrictEqual({
-				invocationMessage: typeof invocation.invocationMessage === 'string' ? invocation.invocationMessage : invocation.invocationMessage?.value,
-				markdown: typeof message === 'string' ? message : message?.value,
-				toolSpecificData: invocation.toolSpecificData,
-			}, {
-				// Link rewriting drops the label so the renderer shows a file
-				// widget; a local host's message collapses to the same form.
-				invocationMessage: 'Edit [](file:///workspaces/simple-server/index.js)',
-				markdown: 'Edit [](file:///workspaces/simple-server/index.js)',
-				// The message names the file, so raw input would only repeat it.
-				toolSpecificData: undefined,
-			});
-		});
-
-		test('normalizes a Windows host path regardless of the client platform', () => {
-			// `URI.file` only rewrites separators when the *client* runs
-			// Windows, so a Windows host paired with a POSIX client would
-			// otherwise yield a single-segment basename.
-			const tc: ToolCallPendingConfirmationState = {
-				toolCallId: 'tc-write-win',
-				toolName: 'str_replace_editor',
-				displayName: 'Edit',
-				invocationMessage: 'Edit file',
-				status: ToolCallStatus.PendingConfirmation,
-				toolInput: 'C:\\repo\\src\\index.ts',
-				_meta: { requestId: 'req-w2', promptRequest: { kind: 'write', fileName: 'C:\\repo\\src\\index.ts' } },
-			};
-
-			const invocation = toolCallStateToInvocation(tc);
-			const message = invocation.invocationMessage;
-
-			assert.strictEqual(
-				typeof message === 'string' ? message : message?.value,
-				'Edit [](file:///c%3A/repo/src/index.ts)',
-			);
-		});
-
-		test('keeps the host message for a write permission that names no file', () => {
-			const tc: ToolCallPendingConfirmationState = {
-				toolCallId: 'tc-write-nofile',
-				toolName: 'str_replace_editor',
-				displayName: 'Edit',
-				invocationMessage: 'Edit file',
-				status: ToolCallStatus.PendingConfirmation,
-				toolInput: '{"path":"/tmp/a.txt"}',
-				_meta: { requestId: 'req-w3', promptRequest: { kind: 'write' } },
-			};
-
-			const invocation = toolCallStateToInvocation(tc);
-			const state = invocation.state.get();
-			const message = state.type === IChatToolInvocation.StateKind.WaitingForConfirmation
-				? state.confirmationMessages?.message
-				: undefined;
-
-			assert.deepStrictEqual({
-				message,
-				toolSpecificData: invocation.toolSpecificData,
-			}, {
-				message: 'Edit file',
-				toolSpecificData: { kind: 'input', rawInput: { path: '/tmp/a.txt' } },
-			});
-		});
-
 		test('sets subagent toolSpecificData from _meta for subagent toolKind', () => {
 			const tc = createToolCallState({
 				_meta: { toolKind: 'subagent', subagentDescription: 'Review code', subagentAgentName: 'code-reviewer' },