Addressed Copilot review: removed artifacts, fixed import + perf

Author: mulhamfetna

.github/copilot-instructions.md

@@ -23,7 +23,42 @@
 				"--use-daemon",
 				"-vv"
 			]
+		},
+		"playwright-mcp": {
+			"type": "stdio",
+			"command": "npx",
+			"args": [
+				"-y",
+				"@playwright/mcp"
+			]
+		},
+		"filesystem-mcp": {
+			"type": "stdio",
+			"command": "npx",
+			"args": [
+				"-y",
+				"@modelcontextprotocol/server-filesystem",
+				"${workspaceFolder}"
+			]
+		},
+		"github-mcp": {
+			"type": "stdio",
+			"command": "npx",
+			"args": [
+				"-y",
+				"@modelcontextprotocol/server-github"
+			],
+			"env": {
+				"GITHUB_PERSONAL_ACCESS_TOKEN": "${input:github_pat}"
+			}
 		}
 	},
-	"inputs": []
+	"inputs": [
+		{
+			"type": "promptString",
+			"id": "github_pat",
+			"description": "GitHub Personal Access Token for @modelcontextprotocol/server-github",
+			"password": true
+		}
+	]
 }

.vscode/mcp.json

@@ -0,0 +1,318 @@
+# VS Code Issue #246116 Progress Report (Arabic RTL Rendering)
+
+## 1) Executive Summary
+
+This report documents all work completed so far on **microsoft/vscode#246116** (Arabic RTL text rendering in editor), plus exact setup/install steps to unblock the remaining environment issues.
+
+Status:
+
+- ✅ Implemented a scoped, opt-in fix (`editor.rtlAutoDetect`) in editor rendering direction logic.
+- ✅ Added targeted automated tests for Arabic/mixed RTL-LTR behavior and regression safety.
+- ✅ TypeScript compile-check passed.
+- ✅ Targeted browser tests for the new behavior passed in Chromium and Firefox.
+- ✅ Full Chromium browser unit suite ran successfully.
+- ⚠️ WebKit remains environment-blocked on this Arch/CachyOS host due Playwright WebKit runtime ABI/display issues (details in section 9).
+
+---
+
+## 2) Repository/Workflow Changes Completed
+
+### A. Copilot and MCP setup work
+
+1. Updated `.github/copilot-instructions.md` with:
+   - Build/lint/test commands
+   - Architecture summary
+   - Key repo conventions
+   - A dedicated phased workflow for issue #246116
+
+2. Updated `.vscode/mcp.json` and configured:
+   - `playwright-mcp`
+   - `filesystem-mcp`
+   - `github-mcp` (token via secure prompt input)
+
+### B. Issue #246116 code implementation
+
+Implemented an opt-in editor setting and line-direction auto-detection path:
+
+#### 1) `src/vs/editor/common/config/editorOptions.ts`
+
+- Added new public editor option in `IEditorOptions`:
+  - `rtlAutoDetect?: boolean;`
+- Added new enum entry:
+  - `EditorOption.rtlAutoDetect`
+- Registered option in `EditorOptions`:
+  - key: `rtlAutoDetect`
+  - default: `false`
+  - localized description
+
+#### 2) `src/vs/editor/common/viewModel/viewModelImpl.ts`
+
+Changed text-direction computation flow:
+
+- Function signature changed from:
+  - `_getTextDirection(lineNumber, decorations)`
+  - to `_getTextDirection(lineNumber, lineContent, decorations)`
+
+- New behavior:
+  1. If decorations force RTL/LTR, decoration wins.
+  2. If decoration vote is neutral:
+     - If `editor.rtlAutoDetect === true` and `strings.containsRTL(lineContent)`, return RTL.
+  3. Else return LTR.
+
+- Wired callers:
+  - `getTextDirection(...)`
+  - view line rendering data creation (`_getViewLineRenderingData(...)`)
+
+#### 3) `src/vs/editor/test/browser/viewModel/viewModelImpl.test.ts`
+
+Added tests:
+
+1. `rtlAutoDetect renders Arabic text as RTL when enabled`
+2. `rtlAutoDetect keeps Arabic text as LTR when disabled`
+3. `rtlAutoDetect still allows forcing LTR direction via decorations`
+4. `rtlAutoDetect renders ASCII-only lines as LTR`
+
+---
+
+## 3) Validation and Results
+
+## 3.1 Compile / type-check
+
+- Command:
+  - `npm run compile-check-ts-native`
+- Result:
+  - ✅ Passed
+
+## 3.2 Targeted test run for the new RTL behavior
+
+- Command:
+  - `node test/unit/browser/index.js --run src/vs/editor/test/browser/viewModel/viewModelImpl.test.ts --grep rtlAutoDetect`
+- Result:
+  - ✅ `4 passing`
+
+## 3.3 Full browser suite (Chromium)
+
+- Command:
+  - `node test/unit/browser/index.js --browser chromium`
+- Result:
+  - ✅ `17602 passing`, `117 pending`
+  - (No failure caused by this RTL change)
+
+## 3.4 Full browser suite (Chromium + Firefox)
+
+- Command:
+  - `node test/unit/browser/index.js --browser chromium --browser firefox`
+- Result:
+  - ⚠️ Ended with `3 failing`, all in `DefaultSettings` (preferences grouping tests), unrelated to RTL changes.
+  - New RTL tests pass in Firefox.
+
+## 3.5 Full all-browser suite (default: Chromium + Firefox + WebKit)
+
+- Command:
+  - `node test/unit/browser/index.js`
+- Result:
+  - ❌ WebKit path unstable in this environment.
+  - Initial failures were missing legacy sonames (`icu66`, `libwebp.so.6`, `libffi.so.7`, etc.), which were installed.
+  - Remaining WebKit failure is runtime-level (WPE/EGL + ABI interaction), not RTL test logic.
+
+---
+
+## 4) Environment Work Completed
+
+1. Detected host package manager:
+   - `pacman` (Arch)
+
+2. Installed Node Version Manager (nvm) and switched to Node 22:
+   - Node 22 is required by this repo (preinstall check rejects Node 25).
+
+3. Reinstalled dependencies under Node 22:
+   - `npm install`
+
+4. Installed Playwright browsers:
+   - `npm run playwright-install`
+
+5. Confirmed runtime mismatch issue for WebKit binary:
+   - WebKit build expects older sonames (`.so.66`, `.so.7`, etc.) not present in current base system.
+
+---
+
+## 5) Current File Delta
+
+Modified files in working tree:
+
+- `.github/copilot-instructions.md`
+- `.vscode/mcp.json`
+- `src/vs/editor/common/config/editorOptions.ts`
+- `src/vs/editor/common/viewModel/viewModelImpl.ts`
+- `src/vs/editor/test/browser/viewModel/viewModelImpl.test.ts`
+
+---
+
+## 6) How to Install What Is Still Needed
+
+You asked specifically how to install the missing requirements. Use the following sequence on Arch Linux.
+
+## 6.1 Required baseline toolchain
+
+```bash
+sudo pacman -Syu --needed curl git base-devel
+```
+
+## 6.2 Install and use Node 22 (required by VS Code repo)
+
+```bash
+curl -fsSL https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.3/install.sh | bash
+export NVM_DIR="$HOME/.nvm"
+source "$NVM_DIR/nvm.sh"
+nvm install 22
+nvm use 22
+nvm alias default 22
+node --version
+npm --version
+```
+
+Expected: Node v22.x
+
+## 6.3 Install repo deps and browsers
+
+```bash
+cd /path/to/vscode
+npm install
+npm run playwright-install
+```
+
+## 6.4 Install browser runtime libraries (system-wide)
+
+### Common Playwright/browser deps
+
+```bash
+sudo pacman -S --needed \
+  nss nspr atk at-spi2-atk gtk3 pango cairo \
+  libxcomposite libxdamage libxrandr libxkbcommon \
+  alsa-lib mesa dbus-glib glib2 libdrm \
+  libxml2 libwebp libffi icu
+```
+
+### Important note for WebKit on Arch
+
+Playwright’s Linux WebKit binary in this run expects older ABI sonames:
+
+- `libicudata.so.66`, `libicui18n.so.66`, `libicuuc.so.66`
+- `libxml2.so.2`
+- `libwebp.so.6`
+- `libffi.so.7`
+
+Modern Arch ships newer sonames (e.g. ICU 78, libffi 8, libwebp 7, libxml2 16).  
+So full all-browser execution may still fail unless you provide compatibility packages.
+
+#### Option A (recommended): run without WebKit when validating this fix
+
+```bash
+node test/unit/browser/index.js --browser chromium
+node test/unit/browser/index.js --browser firefox
+```
+
+This validates the editor RTL fix robustly for this issue.
+
+#### Option B: add compatibility libraries for WebKit
+
+Use an AUR helper (if you use one) to install legacy compatibility packages (names can vary over time):
+
+```bash
+yay -Ss 'icu66|libffi7|libwebp6|libxml2-legacy'
+```
+
+Then install the available matching compatibility packages and rerun:
+
+```bash
+node test/unit/browser/index.js
+```
+
+If your mirror/repo set does not provide these compat packages, use a containerized Ubuntu-based test environment for full WebKit runs.
+
+---
+
+## 7) Commands to Reproduce My Validation Exactly
+
+```bash
+export NVM_DIR="$HOME/.nvm"
+source "$NVM_DIR/nvm.sh"
+nvm use 22
+
+npm run compile-check-ts-native
+npm run transpile-client
+
+# Targeted fix tests
+node test/unit/browser/index.js --browser chromium --run src/vs/editor/test/browser/viewModel/viewModelImpl.test.ts --grep rtlAutoDetect
+node test/unit/browser/index.js --browser firefox --run src/vs/editor/test/browser/viewModel/viewModelImpl.test.ts --grep rtlAutoDetect
+
+# Full suites
+node test/unit/browser/index.js --browser chromium
+node test/unit/browser/index.js --browser chromium --browser firefox
+# (WebKit requires additional compat libs on Arch)
+```
+
+---
+
+## 8) Practical Next Step
+
+Use Chromium+Firefox as the reliable validation path for this issue on this machine, then proceed to PR prep.
+
+---
+
+## 9) Deep Debug Findings for WebKit (Post-Library Install)
+
+After installing missing compatibility libraries, WebKit still fails in this host setup due environment/runtime mismatch.
+
+### 9.1 What was reproduced
+
+1. Without preload, Playwright WebKit launcher fails with GLib symbol errors (`g_once_init_enter_pointer` / `g_once_init_leave_pointer`).
+2. With preload:
+
+```bash
+LD_PRELOAD='/usr/lib/libglib-2.0.so.0 /usr/lib/libgobject-2.0.so.0 /usr/lib/libgio-2.0.so.0' node test/unit/browser/index.js --browser=webkit --grep rtlAutoDetect
+```
+
+WebKit can start further, but WPE headless path fails on EGL display creation and test run can stall.
+
+### 9.2 Root cause
+
+- Playwright Linux WebKit bundle and host system libraries have ABI/runtime mismatches.
+- Headless WebKit path uses WPE (`pw_run.sh` selects WPE when `--headless`) and fails in this display stack.
+- VS Code browser harness waits on renderer completion; if browser startup fails before normal completion/cleanup, external timeout is needed to avoid indefinite waiting.
+
+### 9.3 Deterministic workaround (no stuck runs)
+
+Use external `timeout` wrappers and scoped runs:
+
+```bash
+timeout 300s npm run -s compile-check-ts-native
+timeout 480s node test/unit/browser/index.js --browser chromium --sequential --run src/vs/editor/test/browser/viewModel/viewModelImpl.test.ts --grep rtlAutoDetect
+timeout 480s node test/unit/browser/index.js --browser firefox --sequential --run src/vs/editor/test/browser/viewModel/viewModelImpl.test.ts --grep rtlAutoDetect
+```
+
+Optional bounded WebKit diagnostics (expected flaky here):
+
+```bash
+timeout 240s env LD_PRELOAD='/usr/lib/libglib-2.0.so.0 /usr/lib/libgobject-2.0.so.0 /usr/lib/libgio-2.0.so.0' \
+  node test/unit/browser/index.js --browser=webkit --sequential --run src/vs/editor/test/browser/viewModel/viewModelImpl.test.ts --grep rtlAutoDetect
+```
+
+### 9.4 Safe WebKit runner script
+
+Created non-repo helper script with timeout + cleanup to prevent hangs:
+
+- `/home/mulham/.copilot/session-state/0bd31df8-855f-4561-8808-368d3300b5e5/files/run-webkit-tests-safe.sh`
+
+Example:
+
+```bash
+TIMEOUT_SECONDS=180 GREP_PATTERN=rtlAutoDetect /home/mulham/.copilot/session-state/0bd31df8-855f-4561-8808-368d3300b5e5/files/run-webkit-tests-safe.sh
+```
+
+---
+
+Once you choose to continue with Chromium+Firefox validation path, I can proceed immediately with:
+
+1. Running your preferred “full” suite in your target environment.
+2. Preparing a clean commit for #246116 with a PR-ready description.