Skip to content

Formatting [dotenv] against my explicit consent #201587

@flexchar

Description

@flexchar

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.85.1
Commit: 0ee08df
Date: 2023-12-13T09:48:16.874Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 23.2.0

Steps to Reproduce:

  1. Open .env file and save.
  2. It will get formatted if defaultFormatter is set, or show a pop asking to configure one.

GUI Example:

  • getting a popup if I hide default formatter in the settings as such
"[dotenv]": {
    // "editor.defaultFormatter": "foxundermoon.shell-format",
    "editor.formatOnSave": false,
    "editor.codeActionsOnSave": {
        "source.fixAll": false,
        "formatOnSave": false
    }
}

image

  • file gets formatted against my explicit consent stating "editor.formatOnSave": false when settings are
 "[dotenv]": {
    "editor.defaultFormatter": "foxundermoon.shell-format",
    "editor.formatOnSave": false,
    "editor.codeActionsOnSave": {
        "source.fixAll": false,
        "formatOnSave": false
    }
}

I observe the same behaviour with editor.formatOnSave set to false globally.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions