Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open File button in Refactor Preview diff opens temp result instead of the file #219006

Open
Colengms opened this issue Jun 27, 2024 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug multi-diff-editor Multi diff editor issues
Milestone

Comments

@Colengms
Copy link
Contributor

Does this issue occur when all extensions are disabled?: No (My repro requires a Rename provider that returns unconfirmed results)

Version: 1.91.0-insider (user setup)
Commit: cb9d1e4
Date: 2024-06-27T05:50:21.997Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Windows_NT x64 10.0.22631

The "Open File" button in the Refactor Preview diff view seems to be opening the wrong 'file'. Instead of opening the existing file, it opens temporary rename preview results for the file. Given that the button is titled just "Open File", I would expect it to open the file and not the temp contents.

PreviewOpen.mp4
@jrieken jrieken assigned hediet and unassigned jrieken Jun 28, 2024
@hediet hediet added bug Issue identified by VS Code Team member as probable bug multi-diff-editor Multi diff editor issues labels Jun 28, 2024
@hediet hediet added this to the July 2024 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug multi-diff-editor Multi diff editor issues
Projects
None yet
Development

No branches or pull requests

3 participants