-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tree-sitter
doesn't apply some other scopes
#241001
Comments
|
Fixed spread earlier this month: #239790 We can fudge
Adding, but I think your theme has multiple scopes listed for this one, and targetting it still won't work correctly with tree sitter. I'll try to address this in a later PR.
This seems to be working already.
Requires injected languages, which I'm planning to start working on this week (won't be ready for the Feb release though). PR incoming for all the others! |
Tried it latest Insiders: f238618 . Most of the issues seems to be fixed.
|
TM | tree-sitter |
---|---|
![]() |
![]() |
Object property colon is fixed but punctuation on types not colorized now:
function bar(a?: string): string { return '' }// ?✅ :🟥 :🟥
interface A {
b?: 2;// ?🟥 :🟥
a: 1;// :🟥
}
const obj = {
a: 1,// ✅
};
TM | tree-sitter |
---|---|
![]() |
![]() |
1. Spread operator color bleeds into variable name (
obj1
)2. Parameter
variable.parameter
(param
)3. Language constants
constant.language.nan
constant.language.infinity
constant.language.undefined
constant.language.null
4.
entity.name.type
(One
)5.
keyword.operator.type
(&
,|
)6.
keyword.operator.optional
applied where it shouldn't (object property, not type) (:
)7
variable.language.this
works### 7. `variable.language.this` ```ts class Foo { constructor() { this } } ```8.
punctuation.definition.typeparameters
(<>
)9.
new.expr entity.name.type
(URL
)10.
support.type.primitive
(unknown
)The text was updated successfully, but these errors were encountered: