-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility: Screen readers cut off lines in latest insider build #237493
Comments
Do you have any settings that could explain this? Nothing that I know of has changed and I cannot reproduce the issue. |
Nope, yesterday everything was normal, today after the update it's like this. Nothing touched, tried to disable all extensions. If the editor window is smaller, it gets even worse. Like (it's PHP code but doesn't matter): the line |
which screen reader are you using? have you tried others? |
JAWS and NVDA, both latest versions. |
@rperez030 or @jooyoungseo, can you reproduce? I don't have my windows computer atm. |
@Menelion could you please share a file where you experience this problem? So far, I cannot reproduce it either. Maybe my lines are not long enough :). |
@meganrogge @rperez030 I have the same issue. This needs to be addressed asap. Copy and paste the following text into a new editor and test with JAWS and NVDA: The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. Previously, all the content on the same line was read aloud unless they had a hard return. Currently, a soft line break is introduced even for screen readers and some words are cut off like this:
There are missing words between two lines. |
Thanks @jooyoungseo. i can reproduce it now. @meganrogge @isidorn this is an extremely critical issue. I think this is related to #229051. We discussed this problem back then. The workaround is to add |
Thank you both for investigating and calling this to my attention. It makes sense that I could not reproduce as I had disabled that setting. We will ensure it's fixed promptly. @aiday-mar , while looking for a permanent fix, I suggest disabling |
Thanks folks! Do you know if this is related or not? Approximately from the same time both JAWS and NVDA started reading a non-existing right brace. I'll explain. |
Hi @meganrogge thank you for the ping and apologies for the issue. I will disable the edit context for screen reader users and will look for a fix. |
I have the following PR which disables the edit context: #238112. I will investigate the issue more in depth |
I am trying to reproduce this issue. I am currently not able to exactly reproduce the issue described by @jooyoungseo using NVDA on windows. I turned on word wrap and even with a line spread out on several view lines, NVDA still reads the full line. I was running however into another issue while using NVDA, which was that I had to press Escape to move the cursor up and down and be able to navigate. I am not sure if this is an edit context problem or because I was connecting to windows through the dev box and maybe it was an input issue. Screen.Recording.2025-01-17.at.11.20.55.movI then tried with Voice Over on macos and I am not able to reproduce the issue either. Could I ask the users in this thread for your settings, so I can try to reproduce the issue? |
@aiday-mar I have word wrap turned off so line numbers would match what is shown in error messages (like: "error on line 128"). How can I send you my settings please? |
Hi @Menelion thanks for your response. You can copy paste them here, or if there is confidential information if you'd prefer , I can send you an email on your profile email and you can reply with the settings |
@aiday-mar No, by "how" I really meant that, sorry for my stupidness. How do I copy them? Please help me locate the full JSON file you need on Windows. Thanks! |
Hi, ah yes of course, you can run the following command: |
C:\Users\User\AppData\Roaming\Code - Insiders\User\settings.json: {
"editor.accessibilitySupport": "on",
"security.workspace.trust.untrustedFiles": "open",
"update.showReleaseNotes": false,
"java.jdt.ls.androidSupport.enabled": "on",
"java.jdt.ls.java.home": "C:\\Program Files\\Microsoft\\jdk-17.0.11.9-hotspot",
"java.configuration.runtimes": [
{
"default": true,
"name": "JavaSE-17",
"path": "C:\\Program Files\\Microsoft\\jdk-17.0.11.9-hotspot",
}
],
"remote.SSH.remotePlatform": {
"do": "linux",
"alpha": "linux"
},
"security.allowedUNCHosts": [
"wsl.localhost"
],
} |
I am able to reproduce on mac with VoiceOver when I enable |
Make sure you are not using NVDA in browse mode. One way to ensure you are not in browse mode is trying to type some content. You can use NVDA +L (Laptop) or NVDA +Up arrow (desktop) to read the line with the cursor. you can configure your keyboard layout under NVDA menu / Preferences / Keyboard. |
@Menelion Can you please try if disabling "editor.experimentalEditContextEnabled" fix the issue with the right brace? If not, I think we should open a separate issue for that one. |
@rperez030 Yes yes! It fixed the non-existent line announcement issue. Actually, it's not only right brace, it doesn't matter what. To reproduce this, type something in a file and press Enter so the last line is blank, then press Up Arrow, then down Arrow again to read the last line. // CC @meganrogge @aiday-mar |
Type: Bug
In this latest insiders build, screen readers (tested with both JAWS and NVDA) started cutting off lines of code. the amount read is a bit longer than what is visible on screen, but still it's nearly impossible to work because before the whole line was read no matter what.
Please fix or revert this.
VS Code version: Code - Insiders 1.97.0-insider (9b0b13d, 2025-01-08T05:06:32.681Z)
OS version: Windows_NT x64 10.0.26100
Modes:
System Info
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off
A/B Experiments
The text was updated successfully, but these errors were encountered: