Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git - Adopt TextDocument.encoding in favor of jschardet use #240798

Closed
bpasero opened this issue Feb 14, 2025 · 0 comments · Fixed by #241256
Closed

Git - Adopt TextDocument.encoding in favor of jschardet use #240798

bpasero opened this issue Feb 14, 2025 · 0 comments · Fixed by #241256
Assignees
@lszomoru
Labels
feature-request Request for new features or functionality file-encoding File encoding type issues git GIT issues insiders-released Patch has been released in VS Code Insiders
Milestone
February 2025

Comments

@bpasero
Copy link
Member

bpasero commented Feb 14, 2025

With the advent of TextDocument.encoding I wonder if git could drop the use of jschardet and thus validate this new proposed API.
@bpasero bpasero added file-encoding File encoding type issues git GIT issues labels Feb 14, 2025
@lszomoru lszomoru added this to the February 2025 milestone Feb 14, 2025
@lszomoru lszomoru added the feature-request Request for new features or functionality label Feb 14, 2025
@lszomoru lszomoru changed the title Adopt TextDocument.encoding in favor of jschardet use Git - Adopt TextDocument.encoding in favor of jschardet use Feb 14, 2025
@lszomoru lszomoru mentioned this issue Feb 19, 2025
Merged
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lszomoru lszomoru

Labels
feature-request Request for new features or functionality file-encoding File encoding type issues git GIT issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
February 2025
Development

Successfully merging a pull request may close this issue.

Git - remove jschardet microsoft/vscode
2 participants
@bpasero @lszomoru