Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings editor leak #240778

Closed
bpasero opened this issue Feb 14, 2025 · 1 comment · Fixed by #241279
Closed

Settings editor leak #240778

bpasero opened this issue Feb 14, 2025 · 1 comment · Fixed by #241279
Assignees
@rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues
Milestone
February 2025

Comments

@bpasero
Copy link
Member

bpasero commented Feb 14, 2025 

[LEAKED DISPOSABLE] Error: CREATED via:
    at GCBasedDisposableTracker.trackDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:27:23)
    at trackDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:198:24)
    at new Disposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:393:9)
    at new SettingsTreeElement (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/preferences/browser/settingsTreeModels.js:34:9)
    at new SettingsTreeSettingElement (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/preferences/browser/settingsTreeModels.js:86:9)
    at SearchResultModel.createSettingsTreeSettingElement (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/preferences/browser/settingsTreeModels.js:507:25)
    at vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/preferences/browser/settingsTreeModels.js:487:69
    at Array.map (<anonymous>)
    at SearchResultModel.createSettingsTreeGroupElement (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/preferences/browser/settingsTreeModels.js:487:55)
    at SearchResultModel.update (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/preferences/browser/settingsTreeModels.js:437:30)
@bpasero bpasero added the freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues label Feb 14, 2025
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues confirmed Issue has been confirmed by VS Code Team member labels Feb 20, 2025
@rzhao271
Copy link
Contributor

rzhao271 commented Feb 20, 2025 •
edited
Loading

Repro: In OSS, open the Settings editor and switch between the User and Workspace scopes.

@rzhao271 rzhao271 added this to the February 2025 milestone Feb 20, 2025
rzhao271 added a commit that referenced this issue Feb 20, 2025
@rzhao271
debt: fix more Settings editor leaks
85e4687 
Fixes #240778
@rzhao271 rzhao271 mentioned this issue Feb 20, 2025
Merged
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Feb 20, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues
Projects
None yet
Milestone
February 2025
Development

Successfully merging a pull request may close this issue.

debt: fix more Settings editor leaks microsoft/vscode
2 participants
@bpasero @rzhao271