agentHost: Distinguish automatic chat renames (#331378) * agenthost: speed up rename chat tool Avoid enumerating every session when resolving a rename target. Add a targeted registry lookup so rename validation and persistence remain awaited while lookup cost stays constant. Fixes #331110 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agenthost: share live session metadata overlay Reuse one helper for targeted session lookup and listSessions so both paths apply live state consistently. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agenthost: make rename chat non-blocking Return to the agent before session lookup and persistence complete. Serialize queued renames and log deferred failures while retaining targeted session resolution. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agenthost: update merged rename test Wait for the background rename independently while expecting the immediate tool result. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agenthost: simplify background rename Start each rename independently without a sequencer and keep the existing tool description unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Reduce automatic rename noise Mark reminder-driven rename calls so clients can hide successful administrative renames while keeping explicit renames and failures visible. Buffer leading model narration until the rename decision is known, discarding it on automatic rename and restoring it otherwise. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Silence automatic rename output Return no model-facing text from the background rename request and hide marked automatic renames from their initial streaming state so they cannot contribute a transient activity title. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Distinguish automatic chat renames Add an automatic rename_chat argument so reminder-driven renames remain non-blocking while explicit renames await completion and surface failures. Keep the reminder and tests aligned with the execution contract. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Simplify automatic rename hiding Derive automatic rename presentation directly from the resolved tool input instead of tracking rename lifecycle state and buffering model actions in AgentSideEffects. Automatic renames may remain visible while their arguments stream, then hide once automatic:true is available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Silence automatic rename narration Ask the model not to mention reminder-driven automatic chat renames while leaving explicit rename behavior unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Hide rename chat tool calls Follow the GitHub app's pragmatic presentation policy by hiding rename_chat invocations throughout their lifecycle. The automatic argument remains responsible only for non-blocking execution semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Forbid automatic rename narration Explicitly instruct the model not to say or mention the automatic rename before or after the tool call. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Scope rename silence to automatic calls Clarify that rename narration should be suppressed only when the model invokes rename_chat with automatic: true. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Limit rename PR to execution semantics Restore the existing rename presentation and reminder behavior. Keep this PR focused on passing automatic:true for reminder-driven calls and using it to choose non-blocking versus awaited execution. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Align automatic rename reminder tests Update title-controller expectations for the concise automatic rename reminder. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Hide resolved automatic renames Use rename_chat tool input to hide successful automatic calls after arguments resolve while keeping streaming, explicit, failed, and cancelled calls visible. Align tests with the updated reminder wording. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Hide rename while input streams Hide rename_chat invocations by tool name during argument streaming, then reveal explicit calls or keep automatic calls hidden once input resolves. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Reuse rename tool name constant Use SessionServerToolName.RenameChat when matching bare and transport-prefixed rename tool calls. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Align rename reminder wording Update title-controller expectations for the stronger automatic rename narration instruction. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Clarify automatic rename silence Tell the model to emit no text before an automatic rename and not mention it afterward. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Target automatic rename preambles Tell the model to invoke automatic chat renames silently without announcing the rename to the user. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Tighten automatic rename reminder Combine the title and silent-tool guidance into one concise automatic rename instruction. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Forbid automatic rename preambles Make the automatic rename reminder explicitly require a silent tool call without a preamble. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Strengthen automatic rename reminder Update the automatic rename instruction and align its title-controller expectations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Polish automatic rename reminder Use grammatical user-facing wording in the automatic rename host instruction. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Uh oh!

Rename tool is very slow #331110

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions