fix: correctly pass extension's id when version is also provided #279630
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When calling the
workbench.extensions.installExtensioncommand to install the extension[email protected],argargument is split as[id, version]with:vscode/src/vs/workbench/contrib/extensions/browser/extensions.contribution.ts
Line 408 in 1e352e9
extensionsWorkbenchService.installfunction is called with:arg([email protected])id(dbaeumer.vscode-eslint)The
installfunction is expecting anid:vscode/src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts
Line 2454 in 1e352e9