Skip to content

Conversation

@daiyam
Copy link
Contributor

@daiyam daiyam commented Nov 26, 2025

Hi,

When calling the workbench.extensions.installExtension command to install the extension [email protected],

  • the arg argument is split as [id, version] with:

const [id, version] = getIdAndVersion(arg);

  • then, the extensionsWorkbenchService.install function is called with:

The install function is expecting an id:

installableInfo = { id: arg, version: installOptions.version, preRelease: installOptions.installPreReleaseVersion ?? this.extensionManagementService.preferPreReleases };

Copilot AI review requested due to automatic review settings November 26, 2025 16:59
Copilot finished reviewing on behalf of daiyam November 26, 2025 17:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the workbench.extensions.installExtension command where the extension ID with version (e.g., [email protected]) was being passed to extensionsWorkbenchService.install() instead of just the ID (e.g., dbaeumer.vscode-eslint). The fix ensures that after splitting the argument into ID and version, only the ID is passed to the install function, while the version is passed separately in the options object.

Key Changes:

  • Fixed the workbench.extensions.installExtension command to pass only the extension ID to extensionsWorkbenchService.install() when a version is specified, instead of passing the full argument with version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants