Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python uses wrong randomizer version #28

Closed
fenhl opened this issue Jul 15, 2023 · 0 comments
Closed

Python uses wrong randomizer version #28

fenhl opened this issue Jul 15, 2023 · 0 comments
Labels
status: released Addressed in the latest release type: bug Something isn't working

Comments

@fenhl
Copy link
Member

fenhl commented Jul 15, 2023

I believe the cause of intermittent failures to recognize some item names in spoiler logs is that there's something wrong with the logic used for importing Python modules from a specific randomizer version. Maybe a race condition between multiple different versions being used at the same time or something. The fix would probably be to cleanly separate Python interpreter instances between randomizer versions. Ideally, this would be achieved using PyO3/pyo3#576, but until that feature is ready, running Python interpreters as subprocesses should be a (less performant) workaround.

@fenhl fenhl added the type: bug Something isn't working label Jul 15, 2023
@fenhl fenhl closed this as completed in a0c6afd Nov 2, 2023
@fenhl fenhl added status: pending release Addressed on main but not yet released status: released Addressed in the latest release and removed status: pending release Addressed on main but not yet released labels Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: released Addressed in the latest release type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant