Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seek Keyframe Next/Prev Skipping Keyframes #1311

Open
4 tasks done
ChicagoScanningMG opened this issue Sep 13, 2022 · 4 comments
Open
4 tasks done

Seek Keyframe Next/Prev Skipping Keyframes #1311

ChicagoScanningMG opened this issue Sep 13, 2022 · 4 comments

Comments

@ChicagoScanningMG
Copy link

I have a lot of issues to go through, so in order to make it easier for me to help you, I ask that you please try these things first

Operating System

Windows 10

Steps to reproduce

For the record, I have experienced this issue on both Windows 10 and Mac OS 10.15.7. If I bring in an h.264 file in either the MP4 or MKV container and I skip through the file using the Seek Next/Prev Keyframe buttons it sometime skips around 30min worth of keyframes. If I'm seeking forward, it will skip 30min ahead, but if I then seek backward from there, it will hit all of the expected keyframes, indicating my initial seek forward did indeed skip keyframes.

I've have encountered this with files created by both Elgato Video Capture and OBS.

Expected behavior

Seek Next/Prev Keyframe buttons should go directly to the Next or Previous keyframe respectively. Keyframes should never be skipped.

Actual behavior

Sometimes when Seeking through keyframes, upwards of 30min worth of keyframes are skipped.

Share log

No response

@mifi
Copy link
Owner

mifi commented Sep 29, 2022

possibly related #1018

@ChicagoScanningMG
Copy link
Author

Ah, so is this likely because the keyframe buffer isn't fully loaded?

@mifi
Copy link
Owner

mifi commented Sep 29, 2022

Yes, loading keyframes can take a long time on long videos. That's why it's only loaded near the cursor. Not sure how to best solve it, but maybe if the user is on the last keyframe of a keyframe window, then we should not allow to skip to the next keyframe...

@ChicagoScanningMG
Copy link
Author

I like that idea. It seems to only happen to me when I'm mashing the keyframe button. I wouldn't mind if there was a delay before it jumped to the next key frame while it buffered more key frames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants