Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIM/DISM: Itinerary name should be changed to something imagestream specific #1070

Open
pranavgaikwad opened this issue Apr 13, 2021 · 0 comments
Open

DIM/DISM: Itinerary name should be changed to something imagestream specific #1070

pranavgaikwad opened this issue Apr 13, 2021 · 0 comments
Assignees
@sseago
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@pranavgaikwad
Copy link
Contributor

Describe the bug
Currently, DIM & DISM itineraries are called 'PVC'. They should be named to something imagestream/images specific:

https://github.com/konveyor/mig-controller/blob/b293c8731dba63d6774e6682c4e056dea5d60b32/pkg/controller/directimagestreammigration/task.go#L78

https://github.com/konveyor/mig-controller/blob/b293c8731dba63d6774e6682c4e056dea5d60b32/pkg/controller/directimagemigration/task.go#L81

Some good names for the itineraries could be ImageMigration and ImageStreamMigration instead.
@pranavgaikwad pranavgaikwad added the kind/bug Categorizes issue or PR as related to a bug. label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sseago sseago

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sseago @pranavgaikwad