Update NAB object status appropriately if VeleroBackup already exists for the NAB object

[shubham-pampattiwar]

No description provided.

[mateusoliveira43]

Are we able to reproduce this error constantly ❓ I think we talked about this being a corner case

If it is a corner case, would not prioritize it now

[mpryc]

Agree this is corner case as we generate names based on the NAB name, namespace and hash, so it's really corner case to expect VeleroBackup to be there beforehand.

[shubham-pampattiwar]

Right now I get the following status on NAB object if the VeleroBackup object already exists:

status:
  conditions:
  - lastTransitionTime: "2024-05-06T19:11:02Z"
    message: backup accepted
    reason: BackupAccepted
    status: "True"
    type: Accepted
  phase: New
  veleroBackupName: nab-tests-nac-7fbca55475f247
  veleroBackupNamespace: openshift-adp
  veleroBackupStatus:
    completionTimestamp: "2024-05-06T19:09:45Z"
    expiration: "2024-06-05T19:09:35Z"
    formatVersion: 1.1.0
    phase: Completed
    progress:
      itemsBackedUp: 86
      totalItems: 86
    startTimestamp: "2024-05-06T19:09:35Z"
    version: 1

I think we should add some msg related to backup already exists etc

[mateusoliveira43]

@shubham-pampattiwar now I am confused

is not the bug you are worried, but only a feedback message that NAB created Velero Backup ❓

[shubham-pampattiwar]

We want to keep NAB : VeleroBackup :: 1:1

[shubham-pampattiwar]

I will try to reproduce this and comment again

[mateusoliveira43]

@shubham-pampattiwar can you test this in #73 ?

I think the error was related to the race condition I fixed there

On your example #59 (comment)

it failed here

oadp-non-admin/internal/controller/nonadminbackup_controller.go

Lines 306 to 315 in 4b2f57f

	_, errUpdate = function.UpdateNonAdminBackupCondition(ctx, r.Client, logger, nab, nacv1alpha1.NonAdminConditionAccepted, metav1.ConditionTrue, "Validated", "Valid Backup config")
	if errUpdate != nil {
	logger.Error(errUpdate, "Unable to set BackupAccepted Condition: True", nameField, nab.Name, constant.NameSpaceString, nab.Namespace)
	return true, false, errUpdate
	}
	_, errUpdate = function.UpdateNonAdminBackupCondition(ctx, r.Client, logger, nab, nacv1alpha1.NonAdminConditionQueued, metav1.ConditionTrue, "BackupScheduled", "Created Velero Backup object")
	if errUpdate != nil {
	logger.Error(errUpdate, "Unable to set BackupQueued Condition: True", nameField, nab.Name, constant.NameSpaceString, nab.Namespace)
	return true, false, errUpdate
	}

and on the next reconcile it went here

oadp-non-admin/internal/controller/nonadminbackup_controller.go

Line 265 in 4b2f57f

} else {