Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow Non Admin object spec change after Velero object is created #77

Open
mateusoliveira43 opened this issue Sep 9, 2024 · 4 comments

Comments

@mateusoliveira43
Copy link
Contributor

mateusoliveira43 commented Sep 9, 2024

We should write a webhook to validate spec changes.

Example: if user tries to update spec after NonAdminBackup status is created, it should be not allowed.

@mateusoliveira43
Copy link
Contributor Author

As discussed today, we will remove code that updates NAC Spec in Reconcile

We will evaluate in the future if we want to re enable this, for user experience (seeing what VeleroBackup Spec its NonAdminBackup Spec generated)

@shubham-pampattiwar
Copy link
Member

Closing this issue as mentioned in #87

@mateusoliveira43 mateusoliveira43 changed the title Avoid spec change Do not allow Non Admin object spec change after Velero object is created Oct 14, 2024
@mateusoliveira43
Copy link
Contributor Author

Reopening as it has not been fixed yet (there is no safe mechanism that disallows users to change NAB spec after it hits a certain status.phase)

@kaovilai
Copy link
Member

validating admission webhook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants