Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI flake in integration test #93

Open
mateusoliveira43 opened this issue Sep 27, 2024 · 1 comment
Open

CI flake in integration test #93

mateusoliveira43 opened this issue Sep 27, 2024 · 1 comment

Comments

@mateusoliveira43
Copy link
Contributor

Saw a CI flake with integration tests

The Reconcile of NAB took more then one second and it broke the test

Example https://github.com/migtools/oadp-non-admin/actions/runs/11070490617/job/30760280482?pr=91#step:5:95

Possible fixes

Increase timeout

Use Eventually approach

gomega.Eventually(func() (bool, error) {

@mpryc
Copy link
Collaborator

mpryc commented Sep 27, 2024

@mateusoliveira43 Eventually is way better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants