Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe standardize SKIP_* in generate-git-snapshot #179

Open
CyrilBrulebois opened this issue Apr 17, 2017 · 1 comment
Open

Maybe standardize SKIP_* in generate-git-snapshot #179

CyrilBrulebois opened this issue Apr 17, 2017 · 1 comment

Comments

@CyrilBrulebois
Copy link

There are several ways to use SKIP_* variables:

if [ "${SKIP_DCH:-}" = "true" ]
if [ "${SKIP_BRANCH_AND_TAG_HANDLING:-}" = "true" ] ;

if [ -n "${SKIP_GIT_CLEANUP:-}" ] ;
if [ -n "${SKIP_QUILT_CLEANUP:-}" ] ;

It might be nice to standardize on checking whether each variable is set to true? The downside is that people setting the GIT or QUILT one manually might get a different behaviour all of a sudden… On the plus side, one of them is set automatically from another part of the script, and the info message mentions explicitly setting them to true anyway.

No practical issue except for consistency and ease of documentation (another bug report coming up).

@CyrilBrulebois
Copy link
Author

Bug report filed against the website → mika/jenkins-debian-glue.org#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant