Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications are not appearing on Windows 8+ when I distribute the app. #75

Closed
lipis opened this issue Oct 8, 2015 · 11 comments
Closed

Comments

@lipis
Copy link

lipis commented Oct 8, 2015

The app and notifications work perfectly on my development machine (Windows 10) and in my Notification settings I have something like this:

screen shot 2015-10-08 at 13 34 31

And when I'm disabling the toast app there are no more notifications. But when I'm trying it on another machine (Windows 8.1 for example) there are no notifications and no toast in the Notifications. Am I missing something?

(I integrated the node-notifier with Electron)

@lipis
Copy link
Author

lipis commented Oct 8, 2015

I have the following code:

  notifier.notify({
    title: title,
    message: message,
    sound: false,
    wait: true,
    data: data, // custom data
  }, function(error, response) {
    console.log('error', response);
    raygunClient.send(new Error('Notifier Error'), {error, response});
  });

here is the stacktrace and error if it's helpful:

    WindowsToaster.[anonymous] in C:\Users\User\AppData\Local\wire\app-2.2417\resources\app.asar\main.js:97
    unknown.[anonymous] in C:\Users\User\AppData\Local\wire\app-2.2417\resources\app.asar\node_modules\node-notifier\lib\utils.js:165
    unknown.[anonymous] in C:\Users\User\AppData\Local\wire\app-2.2417\resources\app.asar\node_modules\node-notifier\lib\utils.js:53
    ChildProcess.ChildProcess.exithandler in child_process.js:222
    Object.emitTwo in events.js:87
    ChildProcess.ChildProcess.emit in events.js:172
    Object.maybeClose in internal/child_process.js:817
    Process.Process.ChildProcess._handle.onexit in internal/child_process.js:211
error: {
  killed: false
  code: 3762504530
  signal: undefined
  cmd: "C:\Users\User\AppData\Local\Temp\7EEA.tmp -sound false -data [object Object] -m foo -t bar -q true -w true"
}
response: ""

@kurisubrooks
Copy link
Collaborator

I have the same problem ( #76 ). Node-notifier seems to refuse to load if it's in an .asar.
It works fine if you compile it without the use of an asar, incase you need to distribute your app urgently.

I'm waiting for node-notifier to support .asar before I distribute my app 😟

@lipis
Copy link
Author

lipis commented Oct 13, 2015

I'm using the grunt-electron (which is using the electron-packager) and when I'm adding the asar: false then I'm getting the following error:

screen shot 2015-10-13 at 11 15 10

So I might have to wait for the asar support as well :/

@kurisubrooks
Copy link
Collaborator

The problem doesn't look to be with the packager, but because the file name is too long. Try shortening the file name to something like squirrel-installer and try to re-run the build.

@kurisubrooks
Copy link
Collaborator

If this doesn't work, let me know and i'll try to run you through using electron-packager by itself.

@kurisubrooks
Copy link
Collaborator

Duplicate of #76

@lipis
Copy link
Author

lipis commented Oct 13, 2015

You are right it's the grunt-electron-installer problem and I can see that the path or the file name or both are two long and that's why I put the whole thing in the root.. not sure if I can do anything more..

@lipis
Copy link
Author

lipis commented Oct 13, 2015

Changed the build directories.. but the same error:
screen shot 2015-10-13 at 11 44 51

@kurisubrooks
Copy link
Collaborator

Can you try running the command with --force? Let me know if that gives any errors.

@lipis
Copy link
Author

lipis commented Oct 13, 2015

Not much..

@kurisubrooks
Copy link
Collaborator

If you want, you could try running it through electron-packager in the command line.
https://github.com/maxogden/electron-packager#usage

Let me know if you'd like any help with it. It's pretty straight forward though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants