Skip to content
This repository has been archived by the owner on Feb 25, 2021. It is now read-only.

UIView preview has issues during orientation changes #158

Open
jpshelley opened this issue Mar 2, 2020 · 6 comments
Open

UIView preview has issues during orientation changes #158

jpshelley opened this issue Mar 2, 2020 · 6 comments

Comments

@jpshelley
Copy link

When using the pod in my own app and the example app on an iPad, whenever I rotate the screen the view itself no longer retains its original constraints. Most of the time it appears to take on padding on the side. I'll upload an image once I am able to later

@mikebuss
Copy link
Owner

mikebuss commented Mar 2, 2020

@jpshelley can you try comparing your constraints to those in the sample application included in the Project folder of this repo? If you are able to reproduce this issue in the sample app, that would be helpful for debugging this.

@mikebuss
Copy link
Owner

mikebuss commented Mar 3, 2020

I am going to close this issue for now. @jpshelley if you can reproduce this issue in the included demo projects, please feel free to update this ticket. If you are not able to reproduce the issues in the demo project, it's likely an issue with your constraints.

If there's something specific you're trying to achieve, you may want to update the demo projects to see what step introduces the issue.

@mikebuss mikebuss closed this as completed Mar 3, 2020
@jpshelley
Copy link
Author

jpshelley commented Mar 3, 2020

Yes I can reproduce it in the example app even. I'll upload an image/video sometime this week.

@sashahilton00
Copy link

@mikebuss this issue is indeed present. I have just seen the behaviour on the sample app. You can see the problem in the video uploaded here: Streamable essentially, the library ceases to recognize codes on an orientation change, requiring a restart of the scanner before it starts recognising again.

@mikebuss
Copy link
Owner

Thanks @sashahilton00. I'll reopen this and take a look. It may be that you need to supply a new scanRect when the orientation changes, but I'll update the ticket with what I find.

@mikebuss mikebuss reopened this Jul 16, 2020
@mikebuss
Copy link
Owner

mikebuss commented Oct 1, 2020

Sorry for the delay in responding to this.

I am not longer actively maintaining this library, but if anyone reading this has a solution and wants to submit a pull request I will merge it in. Apologies for the inconvenience.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants