chore: address PR #5 review comments — replace cross-package relative imports, pin ESLint ecmaVersion=2023, simplify globs + ci(gha): set cache-dependency-path (#6)

* feat: bootstrap monorepo with ESM-only config packages and Changesets initial release

* chore: convert .mjs entrypoints; ESLint deps cleanup; Prettier semi=false; align root TS to ES2023

* docs(tsconfig): document presets (base/node-library/node-test), Node 22 baseline, JSON config rationale, and usage examples

* docs(tsconfig): align base preset to ES2023 target/lib and update README accordingly

* ci(gha): rely on pnpm/action-setup@v4 packageManager auto-pinning; drop unsupported package_json_file input

* refactor(config): move eslint/prettier configs to config.mjs and re-export from index.mjs; include config.mjs in package files

* chore: add per-package ESLint/Prettier configs; format and lint package .mjs files

* build(eslint-config): import Prettier config by package name in local prettier.config.mjs\n\nReplace cross-package relative import with '@mikecbrant/prettier-config' per PR #5 review (#5 (comment)).

* chore(prettier-config): import sibling ESLint config by package name in eslint.config.mjs

* config(eslint/prettier): replace cross-package relative imports with package-name imports; pin ecmaVersion=2023; simplify globs; export local ESLint config subpath\n\n- packages/eslint-config/prettier.config.mjs: import '@mikecbrant/prettier-config' instead of relative path\n- packages/prettier-config/eslint.config.mjs: re-export '@mikecbrant/eslint-config/eslint.config' (no FS paths)\n- packages/eslint-config/config.mjs: ecmaVersion 2023; collapse files globs to **/*.{js,mjs,jsx,ts,mts,tsx}\n- packages/eslint-config/package.json: add exports './eslint.config' and include file in published files\n- .github/workflows/release.yml: set cache-dependency-path: pnpm-lock.yaml for all setup-node steps\n- package.json/pnpm-lock.yaml: add workspace devDep on @mikecbrant/prettier-config for local Prettier config resolution\n- packages/prettier-config/package.json: add devDep on @mikecbrant/eslint-config for local ESLint config resolution

* chore(lockfile): resolve merge conflicts in pnpm-lock.yaml and normalize quotes

- Resolve merge conflicts from PR #6 while preserving intended config changes
- Normalize package and dependency keys from single quotes to double quotes across snapshots
- No dependency version changes or functional impact; lockfile formatting only
- Ensures ESLint/TypeScript and Changesets config remains intact

* refactor: remove eslint-config subpath export; strip comments; switch prettier-config ESLint import to package root\n\n- packages/eslint-config/package.json: drop exports['./eslint.config'] per PR #6 review\n- packages/eslint-config/prettier.config.mjs: remove leading comment\n- packages/prettier-config/eslint.config.mjs: remove leading comment and import from '@mikecbrant/eslint-config' (not subpath)\n\nScope: address CHANGES_REQUESTED by @mikecbrant on 2025-09-02

* eslint-config: split JS/TS overrides; scope TS parser/resolver to TS globs and enable JSX parsing for JS; make local eslint.config.mjs glob recursive (per PR #6 review)

---------

Co-authored-by: CharlieHelps <[email protected]>
Co-authored-by: Mike Brant <[email protected]>

Author: 3 people

package.json

@@ -15,6 +15,7 @@
   "devDependencies": {
     "@changesets/cli": "^2.28.1",
     "@typescript/native-preview": "^7.0.0-dev.0",
+    "@mikecbrant/prettier-config": "workspace:*",
     "prettier": "^3.3.3",
     "typescript": "^5.6.3"
   }

packages/eslint-config/config.mjs

@@ -13,26 +13,18 @@ export default [
 	// SonarJS recommended (flat)
 	sonarjs.configs.recommended,
 
-	// Strict overlays and additional plugins
+	// TypeScript-specific strict overrides
 	{
-		name: '@mikecbrant/eslint-config/strict-overrides',
-		files: [
-			'**/*.js',
-			'**/*.mjs',
-			'**/*.jsx',
-			'**/*.ts',
-			'**/*.mts',
-			'**/*.tsx',
-			'**/*.d.ts',
-		],
+		name: '@mikecbrant/eslint-config/strict-overrides:ts',
+		files: ['**/*.{ts,tsx,mts}'],
 		plugins: {
 			'@typescript-eslint': tsPlugin,
 			import: importPlugin,
 			unicorn: unicornPlugin,
 			'unused-imports': unusedImports,
 		},
 		languageOptions: {
-			ecmaVersion: 'latest',
+			ecmaVersion: 2023,
 			sourceType: 'module',
 			parser: tsParser,
 			parserOptions: {
@@ -55,7 +47,7 @@ export default [
 			'max-depth': ['error', 3],
 			'max-params': ['error', 4],
 
-			// TS hygiene
+			// TS hygiene (TS-only)
 			'@typescript-eslint/consistent-type-imports': [
 				'error',
 				{ prefer: 'type-imports', fixStyle: 'inline-type-imports' },
@@ -91,6 +83,60 @@ export default [
 		},
 	},
 
+	// JavaScript-specific strict overrides (no TS parser)
+	{
+		name: '@mikecbrant/eslint-config/strict-overrides:js',
+		files: ['**/*.{js,mjs,jsx}'],
+		plugins: {
+			import: importPlugin,
+			unicorn: unicornPlugin,
+			'unused-imports': unusedImports,
+		},
+		languageOptions: {
+			ecmaVersion: 2023,
+			sourceType: 'module',
+			parserOptions: {
+				ecmaFeatures: { jsx: true },
+			},
+		},
+		rules: {
+			// Confirmed strict thresholds (errors)
+			'max-lines-per-function': [
+				'error',
+				{ max: 60, skipComments: true, skipBlankLines: true },
+			],
+			complexity: ['error', 10],
+			'max-depth': ['error', 3],
+			'max-params': ['error', 4],
+
+			// Imports hygiene & sorting (no TS type group here)
+			'import/no-duplicates': 'error',
+			'import/order': [
+				'error',
+				{
+					groups: [
+						['builtin', 'external'],
+						'internal',
+						'parent',
+						'sibling',
+						'index',
+						'object',
+					],
+					alphabetize: { order: 'asc', caseInsensitive: true },
+					'newlines-between': 'always',
+				},
+			],
+			'unused-imports/no-unused-imports': 'error',
+
+			// Misc
+			'no-console': 'error',
+
+			// Tame a few unicorn defaults
+			'unicorn/prevent-abbreviations': 'off',
+			'unicorn/no-null': 'off',
+		},
+	},
+
 	// Explicitly omit CommonJS and TypeScript CJS
 	{ ignores: ['**/*.cjs', '**/*.cts'] },
 ]

packages/eslint-config/eslint.config.mjs

@@ -5,7 +5,7 @@ import unusedImports from 'eslint-plugin-unused-imports'
 
 export default [
 	{
-		files: ['*.mjs'],
+		files: ['**/*.mjs'],
 		languageOptions: {
 			ecmaVersion: 2023,
 			sourceType: 'module',

packages/eslint-config/package.json

@@ -28,6 +28,10 @@
 	"files": [
 		"index.mjs",
 		"config.mjs",
+		"eslint.config.mjs",
 		"README.md"
-	]
+	],
+	"devDependencies": {
+		"@mikecbrant/prettier-config": "workspace:*"
+	}
 }

packages/eslint-config/prettier.config.mjs

@@ -1,2 +1 @@
-// Delegate to the published Prettier config package by name to avoid cross-package relative paths.
 export { default } from '@mikecbrant/prettier-config'

packages/prettier-config/eslint.config.mjs

@@ -1,2 +1 @@
-// Delegate to the published sibling package to avoid cross-package relative imports.
 export { default } from '@mikecbrant/eslint-config'

packages/prettier-config/package.json

@@ -18,5 +18,8 @@
 		"index.mjs",
 		"config.mjs",
 		"README.md"
-	]
+	],
+	"devDependencies": {
+		"@mikecbrant/eslint-config": "workspace:*"
+	}
 }