Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--update has the same behaviour as --update-check #6784

Open
ruben1PvP opened this issue Jan 7, 2025 · 2 comments
Open

--update has the same behaviour as --update-check #6784

ruben1PvP opened this issue Jan 7, 2025 · 2 comments

Comments

@ruben1PvP
Copy link

As the title suggests, using --update only checks what the latest version is but doesn't download and/or installs it, just as --update-check does.

gallery-dl --update -v
[gallery-dl][debug] Version 1.27.6-dev
[gallery-dl][debug] Python 3.11.3 - Windows-10-10.0.19045-SP0
[gallery-dl][debug] requests 2.32.3 - urllib3 2.2.1
[gallery-dl][debug] Configuration Files ['%APPDATA%\\gallery-dl\\config.json']
[update][debug] Using UpdateExtractor for 'update:check'
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): api.github.com:443
[urllib3.connectionpool][debug] https://api.github.com:443 "GET /repos/mikf/gallery-dl/releases/latest HTTP/1.1" 200 1952
[update][info] A new release is available: 1.27.6-dev -> 1.28.3
gallery-dl --update-check -v
[gallery-dl][debug] Version 1.27.6-dev
[gallery-dl][debug] Python 3.11.3 - Windows-10-10.0.19045-SP0
[gallery-dl][debug] requests 2.32.3 - urllib3 2.2.1
[gallery-dl][debug] Configuration Files ['%APPDATA%\\gallery-dl\\config.json']
[update][debug] Using UpdateExtractor for 'update:check'
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): api.github.com:443
[urllib3.connectionpool][debug] https://api.github.com:443 "GET /repos/mikf/gallery-dl/releases/latest HTTP/1.1" 200 1952
[update][info] A new release is available: 1.27.6-dev -> 1.28.3
gallery-dl --version -v
1.27.6-dev

Those three commands were executed one after the other. I don't know if the 443 error is in my end or github's.

@mikf
Copy link
Owner

mikf commented Jan 7, 2025

Non-executable installs provide only -U/--update-check as "update" command-line options, and the allow_abbrev functionality of argparse then completes --update to the full --update-check.

If you want to update gallery-dl, use whatever method you used to install it in the first place, e.g. python -m pip install -U gallery-dl.

@ruben1PvP
Copy link
Author

Non-executable installs provide only -U/--update-check as "update" command-line options, and the allow_abbrev functionality of argparse then completes --update to the full --update-check.

If you want to update gallery-dl, use whatever method you used to install it in the first place, e.g. python -m pip install -U gallery-dl.

Understood, wouldn't be good to make it clear either on the docs or saying it when you run the command? I've seen that yt-dlp does this when you use -U in a yt-dlp installed by pip (it tells you that you cannot run it and you need to run pip install -U yt-dlp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants