Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support number-pad and other keyboard types #12

Open
bolinfest opened this issue Feb 23, 2018 · 1 comment
Open

Support number-pad and other keyboard types #12

bolinfest opened this issue Feb 23, 2018 · 1 comment

Comments

@bolinfest
Copy link

Currently, this check is hardcoded for the numeric keyboard type:

      if (screenY === height || this.props.keyboardType !== 'numeric') {
        bottom = -81;
      } else {
        bottom = endCoordinates.height - 40;
      }

But this does not do the right thing for keyboard types such as number-pad:

https://facebook.github.io/react-native/docs/textinput.html#keyboardtype

(Admittedly, the difference between the two is slight. It seems the only difference is the lack of a decimal point in number-pad mode.)

@mileung
Copy link
Owner

mileung commented Feb 24, 2018

Mm, ok thanks for bringing this up. I guess for now if you're using "number-pad", find a way to pass numeric as a prop to the DoneBar. Too busy with a lot of school-related stuff right now.

or make a pull request =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants