From 974fb6e3c7de9b25e573de31eadf7507c4cefd12 Mon Sep 17 00:00:00 2001
From: Alexandr Guzhva <alexanderguzhva@gmail.com>
Date: Fri, 1 Mar 2024 20:27:32 -0500
Subject: [PATCH] Add missing virtual destructors

Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
---
 cpp/include/milvus-storage/format/reader.h | 2 ++
 cpp/include/milvus-storage/format/writer.h | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/cpp/include/milvus-storage/format/reader.h b/cpp/include/milvus-storage/format/reader.h
index 981f153..6a0e569 100644
--- a/cpp/include/milvus-storage/format/reader.h
+++ b/cpp/include/milvus-storage/format/reader.h
@@ -23,5 +23,7 @@ class Reader {
   virtual void Close() = 0;
 
   virtual Result<std::shared_ptr<arrow::Table>> ReadByOffsets(std::vector<int64_t>& offsets) = 0;
+
+  virtual ~Reader() = default;
 };
 }  // namespace milvus_storage
\ No newline at end of file
diff --git a/cpp/include/milvus-storage/format/writer.h b/cpp/include/milvus-storage/format/writer.h
index ff869e5..766e13e 100644
--- a/cpp/include/milvus-storage/format/writer.h
+++ b/cpp/include/milvus-storage/format/writer.h
@@ -26,5 +26,7 @@ class FileWriter {
   virtual int64_t count() = 0;
 
   virtual Status Close() = 0;
+
+  virtual ~FileWriter() = default;
 };
 }  // namespace milvus_storage