From d2ddcf3c5f366a0abace175afd258b2779c96e26 Mon Sep 17 00:00:00 2001 From: Bingyi Sun Date: Fri, 20 Oct 2023 18:50:01 +0800 Subject: [PATCH] [Go] Fix fragment may not be recorded in manifest issue (#82) Signed-off-by: sunby --- go/storage/transaction/transaction.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/go/storage/transaction/transaction.go b/go/storage/transaction/transaction.go index 6a7a72f..568d2a1 100644 --- a/go/storage/transaction/transaction.go +++ b/go/storage/transaction/transaction.go @@ -111,12 +111,14 @@ func (w *WriteOperation) Execute() error { scalarFragment := fragment.NewFragment() vectorFragment := fragment.NewFragment() + isEmpty := true for w.reader.Next() { rec := w.reader.Record() if rec.NumRows() == 0 { continue } + var err error scalarWriter, err = w.write(scalarSchema, rec, scalarWriter, &scalarFragment, w.options, true) if err != nil { @@ -126,6 +128,7 @@ func (w *WriteOperation) Execute() error { if err != nil { return err } + isEmpty = false } if scalarWriter != nil { @@ -139,7 +142,7 @@ func (w *WriteOperation) Execute() error { } } - if scalarWriter == nil { + if isEmpty { return nil }