enhance: [2.5] skip adding stopping node to resource group in handleNodeUp (#45969) #45982
Conversation
…ilvus-io#45969) Related to milvus-io#45960 Follow-up to milvus-io#45961 After milvus-io#45961 ensured that handleNodeUp is always called for nodes discovered during rewatchNodes (including stopping nodes), this change adds a safeguard in ResourceManager.handleNodeUp to skip adding stopping nodes to resource groups. 1. **resource_manager.go**: Add check for IsStoppingState() in handleNodeUp to prevent stopping nodes from being added to incomingNode set and assigned to resource groups. 2. **server.go**: - Delete processed nodes from sessionMap to avoid duplicate processing in the subsequent loop - Add warning logs for stopping state transitions during rewatch Signed-off-by: Congqi Xia <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
|
[ci-v2-notice]
To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (60.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 2.5 #45982 +/- ##
==========================================
- Coverage 82.10% 82.03% -0.07%
==========================================
Files 1128 1587 +459
Lines 179181 248836 +69655
==========================================
+ Hits 147110 204140 +57030
- Misses 26099 38677 +12578
- Partials 5972 6019 +47
🚀 New features to boost your workflow:
|
|
/lgtm |
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
3 participants
Cherry-pick from master
pr: #45969
Related to #45960
Follow-up to #45961
After #45961 ensured that handleNodeUp is always called for nodes discovered during rewatchNodes (including stopping nodes), this change adds a safeguard in ResourceManager.handleNodeUp to skip adding stopping nodes to resource groups.
resource_manager.go: Add check for IsStoppingState() in handleNodeUp to prevent stopping nodes from being added to incomingNode set and assigned to resource groups.
server.go: