Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug or deadcode in SelectiveSGML2TokenSequence.java #187

Open
thibolu opened this issue Oct 19, 2020 · 0 comments
Open

Bug or deadcode in SelectiveSGML2TokenSequence.java #187

thibolu opened this issue Oct 19, 2020 · 0 comments

Comments

@thibolu
Copy link

thibolu commented Oct 19, 2020

Hello,
I noticed a potential bug in src/cc/mallet/pipe/SelectiveSGML2TokenSequence.java

On lines 92 and 93 of the file, we have:

nextTag = m.group(0);     
nextTag = sgml.substring(1, sgml.length()-1);

I don't have domain knowledge about this algorithm, but it looks suspicious. I believe that either one of the nexTag is incorrect (maybe it should be nextStart?) or if it's not a bug, line 92 is dead code and should be removed to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant