Various changes to the eval history schema service (#3637)

These relate to feedback from the design review, plus making some
changes in light of writing code which uses these tables:

1) Use `ON DELETE CASCADE` for all foreign key references.
2) Use an array of timestamps to store the evaluation instances instead
   of keeping them in a separate table.
3) Change some of the table names. The original names were not
   particular consistent or intuitive.

Since Minder does not use any of these tables at this point, there
should be no impact from these changes.

Author: dmjb

database/migrations/000069_evaluation_history_modifications.down.sql

@@ -0,0 +1,43 @@
+-- Copyright 2024 Stacklok, Inc
+--
+-- Licensed under the Apache License, Version 2.0 (the "License");
+-- you may not use this file except in compliance with the License.
+-- You may obtain a copy of the License at
+--
+--      http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+
+BEGIN;
+
+-- change tables back to old names
+ALTER TABLE evaluation_rule_entities RENAME TO rule_entity_evaluations;
+ALTER TABLE evaluation_statuses RENAME TO evaluation_history;
+ALTER TABLE latest_evaluation_statuses RENAME TO latest_evaluation_state;
+
+-- recreate FKs without ON DELETE CASCADE
+ALTER TABLE rule_entity_evaluations DROP CONSTRAINT evaluation_rule_entities_artifact_id_fkey;
+ALTER TABLE rule_entity_evaluations DROP CONSTRAINT evaluation_rule_entities_repository_id_fkey;
+ALTER TABLE rule_entity_evaluations DROP CONSTRAINT evaluation_rule_entities_pull_request_id_fkey;
+ALTER TABLE remediation_events DROP CONSTRAINT remediation_events_evaluation_id_fkey;
+ALTER TABLE alert_events DROP CONSTRAINT alert_events_evaluation_id_fkey;
+
+ALTER TABLE rule_entity_evaluations ADD FOREIGN KEY (artifact_id) REFERENCES artifacts(id);
+ALTER TABLE rule_entity_evaluations ADD FOREIGN KEY (repository_id) REFERENCES repositories(id);
+ALTER TABLE rule_entity_evaluations ADD FOREIGN KEY (pull_request_id) REFERENCES pull_requests(id);
+ALTER TABLE remediation_events ADD FOREIGN KEY (evaluation_id) REFERENCES evaluation_statuses(id);
+ALTER TABLE alert_events ADD FOREIGN KEY (evaluation_id) REFERENCES evaluation_statuses(id);
+
+-- recreate evaluation_instance table
+ALTER TABLE evaluation_history DROP COLUMN evaluation_times;
+CREATE TABLE evaluation_instance(
+    evaluation_id UUID NOT NULL REFERENCES evaluation_history(id) ON DELETE CASCADE,
+    evaluation_time TIMESTAMP NOT NULL DEFAULT NOW(),
+    PRIMARY KEY (evaluation_id, evaluation_time)
+);
+
+COMMIT;

database/migrations/000069_evaluation_history_modifications.up.sql

@@ -0,0 +1,43 @@
+-- Copyright 2024 Stacklok, Inc
+--
+-- Licensed under the Apache License, Version 2.0 (the "License");
+-- you may not use this file except in compliance with the License.
+-- You may obtain a copy of the License at
+--
+--      http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+
+BEGIN;
+
+-- these changes reflect feedback during design review plus some changes I've
+-- wanted to make after writing queries around these tables.
+
+-- give some of the tables better names
+-- these tables are not yet used in the codebase, so renaming them should be low risk
+ALTER TABLE rule_entity_evaluations RENAME TO evaluation_rule_entities;
+ALTER TABLE evaluation_history      RENAME TO evaluation_statuses;
+ALTER TABLE latest_evaluation_state RENAME to latest_evaluation_statuses;
+
+-- ensure FK cascades are set for entities, and for the alerts/remediations
+ALTER TABLE evaluation_rule_entities DROP CONSTRAINT rule_entity_evaluations_artifact_id_fkey;
+ALTER TABLE evaluation_rule_entities DROP CONSTRAINT rule_entity_evaluations_repository_id_fkey;
+ALTER TABLE evaluation_rule_entities DROP CONSTRAINT rule_entity_evaluations_pull_request_id_fkey;
+ALTER TABLE remediation_events DROP CONSTRAINT remediation_events_evaluation_id_fkey;
+ALTER TABLE alert_events DROP CONSTRAINT alert_events_evaluation_id_fkey;
+
+ALTER TABLE evaluation_rule_entities ADD FOREIGN KEY (artifact_id) REFERENCES artifacts(id) ON DELETE CASCADE;
+ALTER TABLE evaluation_rule_entities ADD FOREIGN KEY (repository_id) REFERENCES repositories(id) ON DELETE CASCADE;
+ALTER TABLE evaluation_rule_entities ADD FOREIGN KEY (pull_request_id) REFERENCES pull_requests(id) ON DELETE CASCADE;
+ALTER TABLE remediation_events ADD FOREIGN KEY (evaluation_id) REFERENCES evaluation_statuses(id) ON DELETE CASCADE;
+ALTER TABLE alert_events ADD FOREIGN KEY (evaluation_id) REFERENCES evaluation_statuses(id) ON DELETE CASCADE;
+
+-- use an array of timestamps instead of a separate table when tracking evaluation instances
+DROP TABLE IF EXISTS evaluation_instance;
+ALTER TABLE evaluation_statuses ADD COLUMN evaluation_times TIMESTAMP[] NOT NULL DEFAULT ARRAY[NOW()]::TIMESTAMP[];
+
+COMMIT;