Skip to content

Commit 0295b85

Browse files
fixed a few more issues in the tests
1 parent 597138d commit 0295b85

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

tests/test_sdk.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1267,9 +1267,9 @@ def check_project_kb(self, project, database, mock_get, mock_del, mock_post, moc
12671267
'model_name': 'openai_rerank',
12681268
'api_key': 'sk-...'
12691269
},
1270+
'metadata_columns': ['date', 'author'],
12701271
'params': {
12711272
'k': 'v',
1272-
'metadata_columns': ['date', 'author']
12731273
}
12741274
}}}
12751275

@@ -1285,12 +1285,8 @@ def check_project_kb(self, project, database, mock_get, mock_del, mock_post, moc
12851285
assert args[0] == f'{DEFAULT_CLOUD_API_URL}/api/projects/{project.name}/knowledge_bases'
12861286
assert kwargs == {'json': {'knowledge_base': {
12871287
'name': 'kb2',
1288-
'embedding_model': None,
1289-
'reranking_model': None,
1290-
'params': {
1291-
'content_columns': ['review'],
1292-
'id_column': 'num'
1293-
},
1288+
'content_columns': ['review'],
1289+
'id_column': 'num',
12941290
'storage': {
12951291
'database': database.name,
12961292
'table': 'tbl1'

0 commit comments

Comments
 (0)