Merge pull request #164 from mindsdb/fix-kb-insert

Fixed inserting into KB

Author: tmichaeldb

mindsdb_sdk/knowledge_bases.py

@@ -159,7 +159,7 @@ def insert(self, data: Union[pd.DataFrame, Query, dict]):
             data_split = data.to_dict('split')
 
             ast_query = Insert(
-                table=Identifier(self.table_name),
+                table=self.table_name,
                 columns=data_split['columns'],
                 values=data_split['data']
             )
@@ -169,7 +169,7 @@ def insert(self, data: Union[pd.DataFrame, Query, dict]):
             # insert from select
             if data.database is not None:
                 ast_query = Insert(
-                    table=Identifier(self.table_name),
+                    table=self.table_name,
                     from_select=query_to_native_query(data)
                 )
                 sql = ast_query.to_string()

tests/test_sdk.py

@@ -1173,6 +1173,23 @@ def check_project_kb(self, project, model, database, mock_post):
                select * from {database.name}.tbl2 where a=1
             )'''
         )
+        kb.insert(
+            database.query('select * from tbl2 limit 1')
+        )
+        check_sql_call(
+            mock_post,
+            f''' insert into {project.name}.{kb.name} (
+               select * from {database.name} (select * from tbl2 limit 1)
+            )'''
+        )
+
+        kb.insert(
+            pd.DataFrame([[1, 'Alice'], [2, 'Bob']], columns=['id', 'name'])
+        )
+        check_sql_call(
+            mock_post,
+            f'''INSERT INTO {project.name}.{kb.name}(id, name) VALUES (1, 'Alice'), (2, 'Bob')'''
+        )
 
         # query
         df = kb.find(query='dog', limit=5).fetch()