Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forced depens on hunger api #64

Open
mckaygerhard opened this issue Oct 28, 2021 · 2 comments
Open

forced depens on hunger api #64

mckaygerhard opened this issue Oct 28, 2021 · 2 comments
Labels
bug Something isn't working question Further information is requested

Comments

@mckaygerhard
Copy link

the commit acd8b26 forces dependency of unnecesary hunger mod.. cos it uses reason that is only defined in hunger api..

so it breaks in other cases.. addition of another dependency is not a way

@BuckarooBanzay BuckarooBanzay added bug Something isn't working question Further information is requested labels Oct 28, 2021
@BuckarooBanzay
Copy link
Member

this only checks if the hunger field is nil on the reason variable, i don't see any depends on a mod there :/
Do you have an error/use-case i can work with?

@mckaygerhard
Copy link
Author

it seems to work.. i have this commit backported in my fork.. i let open for now.. and close in few weeks.. (i am active now.. so dont worry)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants