Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fumaroles in the overworld don't create fire, but do extinguish fire if they're near some #59

Closed
fluxionary opened this issue Nov 12, 2022 · 1 comment · Fixed by #60

Comments

@fluxionary
Copy link
Contributor

a player was trying to use them to add a smoking effect to a bonfire build, but the fire kept going out. it took a while to understand what was going on.

the correct behavior should probably be either:

  1. fumaroles work the same in both the nether and in the "overworld"
  2. fumaroles neither create nor extinguish fire in the "overworld"

i prefer #2, but i thought i'd ask before submitting a PR.

@Treer
Copy link
Collaborator

Treer commented Nov 13, 2022

I agree with your #2 as well, the fire was supposed to be a nether effect so extinguishing fire in the overworld is a bug,

FWIW, my thoughts behind the behaviour difference was:

  • Having a block that's repurposable for e.g. cottage chimneys (or bonfires?) with puffs of smoke provides another 'treasure' to go on an expedition for.
  • The nether needed more danger. Someone in issue 4 said "the only danger is falling down the cliff" and they had a point, so... surprise fire. Unlikely to catch anyone but perhaps it can add some atmosphere when seen in the distance, and reduce any feeling of safety when it happens a little too close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants