Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

technic_cnc_use_technic uses minetest.conf instead of technic.conf #558

Open
Hawk777 opened this issue May 25, 2020 · 2 comments
Open

technic_cnc_use_technic uses minetest.conf instead of technic.conf #558

Hawk777 opened this issue May 25, 2020 · 2 comments

Comments

@Hawk777
Copy link
Contributor

Hawk777 commented May 25, 2020

It seems to me that this setting ought to be world-specific (since the appropriate value AFAICT depends on what other mods are enabled in the world), not global, and therefore ought to use the technic.config table instead of the minetest.settings table. If people agree, I can put together a patch.

@SmallJoker
Copy link
Member

@Hawk777 I think that technic should use a two-layered settings system to cover all use-cases.

local is_active_str = technic.config:get("key") or core.settings:get("key") or "false"
local is_active = core.is_yes(is_active_str)

This however contradicts with the setting technic_cnc_use_technic (on by default), which controls the technic integration. You're right that it depends on the enabled mods - but is that an issue? Is there an unexpected behaviour?

@Hawk777
Copy link
Contributor Author

Hawk777 commented Jan 3, 2025

I guess as written right now it lets you force-disable it but otherwise adapts to whether you have Technic installed or not, which seems like sane behaviour. Honestly I don’t know what I had in mind 4½ years ago. It might be reasonable to do nothing at all and just close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants