Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images in tablecolumn are not scaled #3403

Open
kilbith opened this issue Nov 27, 2015 · 8 comments · May be fixed by #14709
Open

Images in tablecolumn are not scaled #3403

kilbith opened this issue Nov 27, 2015 · 8 comments · May be fixed by #14709
Labels
Bug Issues that were confirmed to be a bug @ Client / Audiovisuals Feature request Issues that request the addition or enhancement of a feature Formspec

Comments

@kilbith
Copy link
Contributor

kilbith commented Nov 27, 2015

@kahrl I notify you since you know the issue.
@VanessaE wants scalable images as well to put icons in the settings tab.

(The bag image is 128x128px, others are 16x16px)
screenshot_20151127_134546
@est31 est31 added Bug Issues that were confirmed to be a bug @ Client / Audiovisuals labels Nov 27, 2015
@rubenwardy rubenwardy added Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible and removed Bug Issues that were confirmed to be a bug labels Jul 26, 2018
@paramat
Copy link
Contributor

paramat commented Oct 9, 2018

Still happening?

@VanessaE
Copy link
Contributor

VanessaE commented Oct 9, 2018

I don't remember what precipitated this, and I have no idea about the mod being shown, but images on a button scale with the button size. Seems to me the same should be true for other uses.

Then again, the last formspec I did was minislots, and everything there works more or less the way one should expect.

@paramat paramat added Possible close Feature request Issues that request the addition or enhancement of a feature Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature. Core dev consideration needed and removed Feature request Issues that request the addition or enhancement of a feature Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature. Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible Possible close labels Oct 9, 2018
@paramat
Copy link
Contributor

paramat commented Oct 11, 2018 •
edited
Loading

This is possibly the relevant code:

minetest/src/gui/guiTable.cpp

Line 386 in b298b03

// Get content width and update xmax

Looks like the image column width 'xmax' is simply set to the largest image's width, so a large image is cut into a strip as in the screenshot.
Commit 8966c16 PR #920 no mention of image scaling in docs or PR, maybe it was assumed only 16px images would be used.

@paramat paramat added Bug Issues that were confirmed to be a bug Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible and removed Bug Issues that were confirmed to be a bug Core dev consideration needed labels Oct 12, 2018
@VanessaE
Copy link
Contributor

To put it simply, "only 16px" is a bad assumption, if that's the case.

@paramat
Copy link
Contributor

paramat commented Aug 9, 2020 •
edited
Loading

Still unconfirmed? Close?

@NathanSalapat
Copy link
Contributor

screenshot_20200808_204950
I believe this is still happening. Although I'm not the one that wrote the code for this.
I have an object here with a 128px texture and it just a strip of it. The mod is commoditymarket_fantasy

@paramat paramat added Bug Issues that were confirmed to be a bug and removed Possible close Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible labels Aug 9, 2020
@paramat
Copy link
Contributor

paramat commented Aug 9, 2020

Thanks.

@v-rob
Copy link
Member

v-rob commented Aug 9, 2020

Tables are a big mess; the code is garbage. There are many bugs with tablecolumns functionality being broken. I personally want to completely rewrite it since it's basically beyond refactor.

@grorp grorp linked a pull request May 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues that were confirmed to be a bug @ Client / Audiovisuals Feature request Issues that request the addition or enhancement of a feature Formspec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GUITable: Scale images with display density / row height grorp/minetest
7 participants
@VanessaE @rubenwardy @paramat @kilbith @est31 @NathanSalapat @v-rob