get_player_window_information() returns nil if called when a player joins

[Zughy]

Minetest version

5.8.0, 5.9.0-dev

Operating system and version

Pop!_OS 22.04 LTS

CPU model

i7-7700

GPU model

GeForce GTX 1060

Summary

Title. The minimum elapsed time since the login required to avoid the nil return on my PC seems to be 0.2412

Steps to reproduce

minetest.register_on_joinplayer(function(player)
        -- Decomment to avoid nil
	--minetest.after(0.2412, function()
		minetest.chat_send_all(dump(minetest.get_player_window_information(player:get_player_name())))
	--end)
end)

[sfan5]

on_joinplayer is called after Server::StageTwoClientInit which should have made everything ready so that the player actually exists in the environment.
However the peer ID in RemotePlayer is only set later here:

minetest/src/server/player_sao.cpp

Lines 86 to 94 in f836a47

	void PlayerSAO::addedToEnvironment(u32 dtime_s)
	{
	ServerActiveObject::addedToEnvironment(dtime_s);
	ServerActiveObject::setBasePosition(m_base_position);
	m_player->setPlayerSAO(this);
	m_player->setPeerId(m_peer_id_initial);
	m_peer_id_initial = PEER_ID_INEXISTENT; // don't try to use it again.
	m_last_good_position = m_base_position;
	}

probable regression from e7dbd32

unfortunately I don't see an easy fix because the need to get the player id before the sao is ready contradicts the design choice made in that commit

[Zughy]

Maybe @SmallJoker can think about something since it was his commit, I don't know

[grorp]

Using the code provided by Zughy, I also get nil on Minetest 5.7.0 and 5.8.0, so this doesn't look like a regression to me.