Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content/pkgmgr unit tests #12295

Open
rubenwardy opened this issue May 8, 2022 · 0 comments · May be fixed by #14763
Open

Add content/pkgmgr unit tests #12295

rubenwardy opened this issue May 8, 2022 · 0 comments · May be fixed by #14763
Labels
Code quality @ Content / PkgMgr Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements

Comments

@rubenwardy
Copy link
Member

rubenwardy commented May 8, 2022

This issue documents everything that should be tested with the content/pkgmgr. This issue can be closed when unit tests are added

Installing content

  • Updating
  • Installing but already exists (return error)
  • Finding base folder

Enabling/disabling mods

  • Dependency cycle
  • Enabling modpack which depends on external mods (both modpack and component mods)
  • Enabling mod with multiple candidates, one of which pre-enabled
  • Enabling mod with unsatisfied dep
  • Enabling mod which depends on world/game mod
  • Recursively enabling dependencies

Mod Configuration / Resolve Dependencies

  • Dependency cycles
  • Missing hard dependency
  • Mod A opt depends on mob B with missing mod C
  • Mod that depends on world/game mod
  • Multiple mods with same name, with no set virtual path load_mod_x = true
  • Game mod opt-dep breaking

Content discovery

  • Finds content from user dir and share
  • Game mods
  • Nested modpacks
  • Virtual paths
  • Content type detection
  • Modname validation
  • Game name/titles?
@rubenwardy rubenwardy added Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements @ Content / PkgMgr Code quality labels May 8, 2022
@rubenwardy rubenwardy changed the title Content/pkgmgr test plan Add content/pkgmgr unit tests Jul 30, 2023
@swagtoy swagtoy linked a pull request Jun 19, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code quality @ Content / PkgMgr Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant