Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "material" Brick to "material" Bricks #3016

Open
Tim79000 opened this issue Feb 26, 2023 · 9 comments
Open

Rename "material" Brick to "material" Bricks #3016

Tim79000 opened this issue Feb 26, 2023 · 9 comments

Comments

@Tim79000
Copy link

It doesn't make sense, because it isn't one brick, it's a block made of multiple.

@appgurueu
Copy link
Contributor

appgurueu commented Feb 26, 2023

First of all: Naming is always debatable. From a technical standpoint however, such a rename is not feasible since it would be breaking compatibility. An alias could be used to work around this to some extent, but still wouldn't preserve compatibility e.g. for raw node.name == "..." checks. It's simply not worth the breakage / effort just for "fixing" a name that "doesn't make sense" (to you).

@appgurueu appgurueu closed this as not planned Won't fix, can't repro, duplicate, stale Feb 26, 2023
@Tim79000
Copy link
Author

I mean, the name that is shown. In the sense that mese blocks used to be called simply "mese"

@Tim79000
Copy link
Author

I don't mean the codename, the codename shouldn't get to be changed. Just the displayed name.

@appgurueu appgurueu reopened this Feb 27, 2023
@appgurueu
Copy link
Contributor

appgurueu commented Feb 27, 2023

Ah okay, that would then be a trivial nonbreaking change (that said, we'd be introducing a display name - technical name inconsistency, which I'm not a fan of).

@Naniono
Copy link

Naniono commented Feb 27, 2023 via email

@Tim79000
Copy link
Author

Tim79000 commented Mar 2, 2023

But it's more of a logical consistency, due to it being more than one brick.

@Tim79000
Copy link
Author

Tim79000 commented Mar 2, 2023

Mese blocks also have this inconsistancy, as previously stated.

@Naniono
Copy link

Naniono commented Mar 2, 2023 via email

@VBPROGER
Copy link

VBPROGER commented May 5, 2023

We will also need to update translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants