Get rid of recursive call in default.dig_up #3133
Open
+35
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
reviewed
Jun 17, 2024
sfan5
reviewed
Jun 17, 2024
sfan5
reviewed
Jun 17, 2024
sfan5
reviewed
Jun 17, 2024
sfan5
reviewed
Jun 17, 2024
SmallJoker
reviewed
Jun 21, 2024
Co-authored-by: SmallJoker <[email protected]>
SmallJoker
reviewed
Jun 26, 2024
Comment on lines
+319
to
+322
| minetest.log("error", "Error raised during `default.dig_up` call:") | ||
| for line in debug.traceback(...):gmatch("([^\n]*)\n?") do | ||
| minetest.log("error", line) | ||
| end |
There was a problem hiding this comment.
As an alternative to manual parsing and outputting - might minetest.error_handler(...) produce better output?
EDIT: This should work: local noerr, success = xpcall(function() bla bla end, minetest.error_handler) and then use the returned values to decide whether or not to reset in_dig_up.
There was a problem hiding this comment.
Weirdly, using minetest.error_handler does not print anything about the error... IDK why.
sfan5
reviewed
Jun 26, 2024
| for line in debug.traceback(...):gmatch("([^\n]*)\n?") do | ||
| minetest.log("error", line) | ||
| end | ||
| end) |
There was a problem hiding this comment.
not sure if to call this clever or a hack but here's a cleaner suggestion:
local in_dig_up = {}
setmetatable(in_dig_up, {__mode = "k"})
function default.dig_up(pos, node, digger, max_height)
local sentinel = {}
if in_dig_up[sentinel] then return end
-- ...
in_dig_up[sentinel] = true
-- ..
-- no resetting needed
endit's even re-entrant
what is going on here? -> https://www.lua.org/pil/17.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3075
This PR fixes the recursive calling of
default.dig_upand adds a parameter for a maximum number of nodes searched.This PR is ready for review.