Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crafting guide does not show recipes that use an alias as output #3117

Open
monk-afk opened this issue May 18, 2024 · 6 comments
Open

Crafting guide does not show recipes that use an alias as output #3117

monk-afk opened this issue May 18, 2024 · 6 comments
Labels

Comments

@monk-afk
Copy link

Recipes registered to the alias

https://github.com/mt-mods/homedecor_modpack/blob/fa3f7f816b18f9aab2df47d05d12d24964817a5e/homedecor_lighting/init.lua#L1886

, its probably something to do with the crafts being registered to the alias that sfinv cant handle
https://github.com/mt-mods/homedecor_modpack/blob/fa3f7f816b18f9aab2df47d05d12d24964817a5e/homedecor_lighting/init.lua#L1658-L1673

mt-mods/homedecor_modpack#41 (comment)

@appgurueu
Copy link
Contributor

appgurueu commented May 19, 2024

This does smell like a bug, but from your description, it's hard to discern what precisely you mean.

It seems homedecor registers aliases and craft recipes using these aliases.

What's wrong? Do these show up incorrectly in the crafting guide? Does crafting not work? Do engine API functions not work?

@wsor4035
Copy link

to hopefully help clarify of what i believe to be the issue:
take an actual node def registration of modname:nodename, then creating an alias for it of modname:someothernodename.
then register crafts to modname:someothernodename.
they wont show up in sfinv, but will in unified inventory since it handles aliases

@monk-afk
Copy link
Author

if it helps, this function will return nil for those nodes registered which has aliases for recipes

minetest.register_on_mods_loaded(function()

However, the recipes do exist and the items can be crafted with the intended recipes, yet the recipes are not shown in the crafting guide.

Screenshots

@appgurueu appgurueu changed the title [Bug] handled aliases of craft recipes Crafting guide does not show recipes that use an alias as output May 19, 2024
@monk-afk
Copy link
Author

@monk-afk
Copy link
Author

Closing ticket since registration works if the alias is registered before the craft.
This also applies to the ordering of available craft outputs: the last registered craft output is shown first, while the first registered craft output is shown last.
I suppose this is an example of stacking.

@wsor4035
Copy link

this shouldnt be closed as the issue isnt fixed (unified inventory handles this)

@monk-afk monk-afk reopened this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants