Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 support #47

Open
PhilPJL opened this issue May 2, 2015 · 9 comments
Open

IE8 support #47

PhilPJL opened this issue May 2, 2015 · 9 comments

Comments

@PhilPJL
Copy link

PhilPJL commented May 2, 2015

I know - IE8. Unfortunately it's still used a lot.
Any chance of better support?

In IE8 the checkbox appears as a coloured rectangle with no text.

@PhilPJL
Copy link
Author

PhilPJL commented May 4, 2015

IE8 doesn't support 'addEventListener' which is used by bootstrap-toggle.

Apparently one work around is:

if (!someElement.addEventListener) {
someElement.attachEvent("onclick", someFunction);
}
else {
someElement.addEventListener("click", someFunction, false);
}

@PhilPJL
Copy link
Author

PhilPJL commented May 4, 2015

Ok, I see, you depend on jQuery 2.0 which isn't right since bootstrap 3 uses jQuery 1.x. Can you change to use jQuery 1.x? Bootstrap 4 will use jQuery 2.

@briansol
Copy link

briansol commented May 6, 2015

jQuery is linked separately and is used in the examples only as an example. just include 1.11.x in your site if you need to support old browsers.

@PhilPJL
Copy link
Author

PhilPJL commented May 6, 2015

My original comment still stands. I will retest. I'm currently using bootstrap-switch which does support IE8 but has other issues.

I hit the jQuery 2 issue when trying to use IE in version 8 compatibility mode on the samples page. Could you change the sample page to link to jQuery 1.11.x?

@briansol
Copy link

briansol commented May 6, 2015

I'm just another user like you... trying to give back a bit to the community for the use of the script. Thus , I can't do anything like that :) only the owner can.

@PhilPJL
Copy link
Author

PhilPJL commented May 7, 2015

Just found #35 which hopefully fixes the IE8 issue.
@minhur any chance these fixes will be merged soon-ish?

@briansol
Copy link

briansol commented May 7, 2015

Neat. If the merge doesn't happen, you can always add it in to source yourself. I just did it to my minified file and it only took about a minuet to manually add in the closing tags.

@paulomcnally
Copy link

Not use IE :)

@philwig
Copy link

philwig commented Oct 15, 2015

Still not working in IE8, which are fully supported by the correct versions of BS3 and JQ.
The issue now is that the button text (in either state) is not readable. Perhaps we can hack around that - I'll post a fix if I can find one. Oh, it seems it's not generating the LABEL tags at all - perhaps that is the same as above, I'll take a look...

... Ok, it's precisely this issue: thanks for flagging it up. That change looks like it'll fix it. Thanks.

We still have about 40% of users who're on this, and although it should die in February next year, I would not hold your breath

Either it supports IE8 (and I can use it), or it does not.
Blaming my the users is arrogant and less than helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants