Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make properties getters and setters public #900

Open
Cologler opened this issue Oct 27, 2023 · 1 comment
Open

Make properties getters and setters public #900

Cologler opened this issue Oct 27, 2023 · 1 comment

Comments

@Cologler
Copy link

Currently API:

var args = new BucketExistsArgs()
    .WithBucket(bucketName);

I cannot read the BucketName property from args for logging, too.

I prefer to use the C# object initializer for better readable (without the With prefix):

var args = new BucketExistsArgs
{
    BucketName = bucketName
};

Why do they use internal as the modifier?

@Cologler
Copy link
Author

Cologler commented Oct 27, 2023

The with keyword of the C# record always returns a new instance, The original instance does not change. However, the minio SDK always modifies the instance itself, which causes a lot of confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant