[player-stats-experience] XP computation is broken since new Hattrick icons

[dominiquelee]

Short description of the problem

XP data fails to load when opening a player's performance history

Any other relevant information. Is it a regression, when it worked/broke etc.

Match type recognition comes from

foxtrick/content/information-aggregation/player-stats-experience.js

Lines 219 to 223 in 3780cd4

	var getBasicGameType = function(node) {
	var gametypeParent = node.querySelector('td.keyColumn');
	var gameTypeImage = gametypeParent.querySelector('.iconMatchtype img');
	return /** @type {MatchTypeClassRaw} */ (gameTypeImage.className);
	};

which reads the class name of the icon of the line.

This value is then compared to module.XP:

foxtrick/content/information-aggregation/player-stats-experience.js

Lines 46 to 52 in 3780cd4

	XP: {
	// assume international friendly as default, considered in min-max,
	// minimum uses 1/2 of this value
	matchFriendly: 0.7,
	matchLeague: 3.5,
	matchCupA: 7.0,
	matchCupB1: 1.75,

However, the class name has changed and is now always match-type-svg

A potential fix would be to extract the .svg URL, remove the version part and use that as a new key in the array. Some examples of value are

• /Img/Svgs/match-types/series.svg?v=1
• /Img/Svgs/match-types/cup.svg?v=1
• /Img/Svgs/match-types/friendly.svg?v=1
• /Img/Svgs/match-types/challenger-cup-2.svg?v=1 (Ruby Cup)
• /Img/Svgs/match-types/nt-worldcup.svg?v=1 (World Cup)
• /Img/Svgs/match-types/nt-cup-europe.svg?v=1 (Europe Cup)
• /Img/Svgs/match-types/masters.svg?v=1

[dominiquelee]

I had another look, thinking we could use a simple Image --> MatchTypeClass mapping, but it's actually not that easy:

• NT friendly uses the same image as regular friendly
• NT KO uses the same image as NT not-KO
• continental cups use different images, but that's probably ok
• Africa's NT and U21 images are reversed, so we definitely need to drop the version when parsing

[SebM668]

@dominiquelee
I sent a message to the CHPP staff, asking if this is how it will be going forward and if they have any suggestions. Worst case they'll tell me to go away, best case...

[SebM668]

@dominiquelee I sent a message to the CHPP staff, asking if this is how it will be going forward and if they have any suggestions. Worst case they'll tell me to go away, best case...

What a waste of time that was. Basically, we do what we want, deal with it.