Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The PHP 7 tests failing on Travis CI #182

Closed
aik099 opened this issue Jun 22, 2017 · 3 comments
Closed

The PHP 7 tests failing on Travis CI #182

aik099 opened this issue Jun 22, 2017 · 3 comments

Comments

@aik099
Copy link
Member

aik099 commented Jun 22, 2017

The PHP 7 tests failing on Travis CI:

https://travis-ci.org/minkphp/MinkZombieDriver/builds/244589944

I guess this is because PHPUnit 6 is picked by Travis CI, which doesn't have PHPUnit_Framework_TestCase class.

Since we can't have test suite compatible with both PHPUnit 5 and PHPUnit 6 the best approach would be to indicating in .travis.yml to use PHPUnit 5 all the time.

Same should be done for other driver repos and main repo because they would fail eventually.

@rpkamp
Copy link

rpkamp commented Mar 26, 2019

PHPUnit is installed through symfony/phpunit-bridge. This is currently pinned to ^4.0 in minkphp/driver-testsuite. This version of symfony/phpunit-bridge is explictly incompatible with PHPUnit 5 and lower (composer conflicts).

So I think the right approach here is not to make everything use PHPUnit 5, but update the tests to be compatible with (at least) PHPUnit 6.

@aik099
Copy link
Member Author

aik099 commented Mar 26, 2019

Sure. Let's do this if that won't increase minimum supported PHP version by driver / test suite itself.

@rpkamp
Copy link

rpkamp commented Mar 26, 2019

I started too, but the saw there already is a PR for this, and the tests are green on that one: #189 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants